Skip to contentSkip to conversation

Checkpatch warnings with pr_fmt()

DISCUSSION Kalle Valo 2 participants 3 messages Apr 12, 2012 – Apr 16, 2012

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

Hi Joe,

due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I had to update checkpatch and now I get lots of useless warnings like this:

drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block comments with only a /* line, use /* comment... drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary after a cast

IMHO they are wrong, at least the style I have tried to enforce in ath6kl is totally opposite (I have "/*\n" on multiline comments and a space after a cast). And at least CodingStyle seems to recommend my style for the multiline comments.

Would you consider removing these two warnings? Or maybe add a new check level so that I can easily disable them?

As I get a lot of patches from people not familiar with the Linux coding style checkpatch is a valuable tool for me, I cannot spot all the style issues by just reviewing the patches. But now checkpatch is useless for me as the real warnings get buried within the noise.

Kalle

author
#1 lore raw
Quoted 15 lines · Kalle Valo

Hi Joe,

due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I had to update checkpatch and now I get lots of useless warnings like this:

drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block comments with only a /* line, use /* comment... drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary after a cast

IMHO they are wrong, at least the style I have tried to enforce in ath6kl is totally opposite (I have "/*\n" on multiline comments and a space after a cast). And at least CodingStyle seems to recommend my style for the multiline comments.

Quoted 7 lines

Would you consider removing these two warnings? Or maybe add a new check level so that I can easily disable them?

As I get a lot of patches from people not familiar with the Linux coding style checkpatch is a valuable tool for me, I cannot spot all the style issues by just reviewing the patches. But now checkpatch is useless for me as the real warnings get buried within the noise.

Forgot to mention that for now I just reverted commit aad4f614983 ("checkpatch: add --strict tests for braces, comments and casts") and checkpatch is usable again. But I hope we find a proper solution for this.

Kalle

#2 lore raw
In reply to Kalle Valo
Quoted 8 lines · Kalle Valo

due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I had to update checkpatch and now I get lots of useless warnings like this:

drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block comments with only a /* line, use /* comment... drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary after a cast

Quoted 4 lines

IMHO they are wrong, at least the style I have tried to enforce in ath6kl is totally opposite (I have "/*\n" on multiline comments and a space after a cast). And at least CodingStyle seems to recommend my style for the multiline comments.

It's the style David Miller prefers for drivers/net. I don't much care one way or another.

Quoted 2 lines

Would you consider removing these two warnings? Or maybe add a new check level so that I can easily disable them?

./scripts/checkpatch.pl --ignore=BLOCK_COMMENT_STYLE <foo>