sanity.bbclass: If the sanity tests fail, don't mark them as complete

PATCH New Richard Purdie 1 participant 1 message Apr 17, 2012

Share & tools

Richard Purdie

author

2012-04-17 11:29 UTC #0 lore raw

PATCH 1/1 sanity.bbclass: If the sanity tests fail, don't mark them as complete

From adf7a93daf5b648972b8d059cba49f28a64efe82 Mon Sep 17 00:00:00 2001
From: Richard Purdie <[email protected]>
Date: Tue, 17 Apr 2012 11:16:18 +0000
Subject:

If the sanity tests fail, we still were writing out the stamp which means they'd get skipped the next time we run bitbake. This is clearly wrong and we should only write out the stamp file if the sanity tests complete successfully.

Signed-off-by Richard Purdie <[email protected]>

---

meta/classes/sanity.bbclass +1 -1

index 1b941ac..4d4abd3 100644
@@ -378,7 +378,7 @@ def check_sanity(e):
         if last_sstate_dir != sstate_dir:
             messages = messages + check_sanity_sstate_dir_change(sstate_dir, e.data)
 
-    if os.path.exists("conf"):
+    if os.path.exists("conf") and not messages:
         f = file(sanityverfile, 'w')
         f.write("SANITY_VERSION %s\n" % sanity_version) 
         f.write("TMPDIR %s\n" % tmpdir)