regulator: userspace-consumer: Convert to use devm_* APIs
PATCH 1/2 regulator: userspace-consumer: Convert to use devm_* APIs
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/userspace-consumer.c | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-)
drivers/regulator/userspace-consumer.c +7 -13
@@ -115,7 +115,9 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)if (!pdata)return -EINVAL ; - drvdata =kzalloc (sizeof (struct userspace_consumer_data ),GFP_KERNEL ); + drvdata =devm_kzalloc (&pdev->dev, +sizeof (struct userspace_consumer_data ), +GFP_KERNEL );if (drvdata ==NULL )return -ENOMEM ;
@@ -125,16 +127,16 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)mutex_init (&drvdata->lock); - ret =regulator_bulk_get (&pdev->dev, drvdata->num_supplies, - drvdata->supplies); + ret =devm_regulator_bulk_get (&pdev->dev, drvdata->num_supplies, + drvdata->supplies);if (ret) {dev_err (&pdev->dev,"Failed to get supplies: %d\n" , ret); - goto err_alloc_supplies; +return ret; } ret =sysfs_create_group (&pdev->dev.kobj, &attr_group);if (ret !=0 ) - goto err_create_attrs; +return ret;if (pdata->init_on) { ret = regulator_bulk_enable(drvdata->num_supplies,
@@ -154,11 +156,6 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev) err_enable:sysfs_remove_group (&pdev->dev.kobj, &attr_group); -err_create_attrs: -regulator_bulk_free (drvdata->num_supplies, drvdata->supplies); - -err_alloc_supplies: -kfree (drvdata);return ret; }
@@ -171,9 +168,6 @@ static int regulator_userspace_consumer_remove(struct platform_device *pdev)if (data->enabled)regulator_bulk_disable (data->num_supplies, data->supplies); -regulator_bulk_free (data->num_supplies, data->supplies); -kfree (data); -return 0 ; }
Signature · 1 line
1.7.5.4
PATCH 2/2 regulator: virtual: Convert to use devm_* APIs
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/virtual.c | 18 +++++------------- 1 files changed, 5 insertions(+), 13 deletions(-)
drivers/regulator/virtual.c +5 -13
@@ -291,18 +291,19 @@ static int __devinit regulator_virtual_probe(struct platform_device *pdev)struct virtual_consumer_data *drvdata;int ret; - drvdata =kzalloc (sizeof (struct virtual_consumer_data ),GFP_KERNEL ); + drvdata =devm_kzalloc (&pdev->dev,sizeof (struct virtual_consumer_data ), +GFP_KERNEL );if (drvdata ==NULL )return -ENOMEM ;mutex_init (&drvdata->lock); - drvdata->regulator =regulator_get (&pdev->dev, reg_id); + drvdata->regulator =devm_regulator_get (&pdev->dev, reg_id);if (IS_ERR (drvdata->regulator)) { ret =PTR_ERR (drvdata->regulator);dev_err (&pdev->dev,"Failed to obtain supply '%s': %d\n" , reg_id, ret); - goto err; +return ret; } ret = sysfs_create_group(&pdev->dev.kobj,
@@ -310,7 +311,7 @@ static int __devinit regulator_virtual_probe(struct platform_device *pdev)if (ret !=0 ) {dev_err (&pdev->dev,"Failed to create attribute group: %d\n" , ret); - goto err_regulator; +return ret; } drvdata->mode =regulator_get_mode (drvdata->regulator);
@@ -318,12 +319,6 @@ static int __devinit regulator_virtual_probe(struct platform_device *pdev)platform_set_drvdata (pdev, drvdata);return 0 ; - -err_regulator: -regulator_put (drvdata->regulator); -err: -kfree (drvdata); -return ret; } static int __devexit regulator_virtual_remove(struct platform_device *pdev)
@@ -334,9 +329,6 @@ static int __devexit regulator_virtual_remove(struct platform_device *pdev)if (drvdata->enabled)regulator_disable (drvdata->regulator); -regulator_put (drvdata->regulator); - -kfree (drvdata);platform_set_drvdata (pdev,NULL );
Signature · 1 line
1.7.5.4
Mark Brown
AppliedQuoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Applied both, thanks.