Skip to contentSkip to conversation

bootimg.bbclass: Tweak iso images to become hybrid images

PATCH In review Richard Purdie 3 participants 4 messages Apr 19, 2012 – Apr 24, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootimg.bbclass: Tweak iso images to become hybrid images

From: Damien Lespiau <[email protected]>

This allows iso images to be written to usb keys and booted on systems which have a BIOS which support this. There is no real down side to tweaking the iso images in this way.

[YOCTO #1763 partial]

---

meta/classes/bootimg.bbclass +2 -0
index f4981d8..370b378 100644
@@ -103,6 +103,8 @@ build_iso() {
 			-r ${ISODIR}
 	fi
 
+	isohybrid ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.iso
+
 	cd ${DEPLOY_DIR_IMAGE}
 	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso
 	ln -s ${IMAGE_NAME}.iso ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso
#1 lore raw
Quoted 5 lines · Richard Purdie

From: Damien Lespiau <[email protected]>

This allows iso images to be written to usb keys and booted on systems which have a BIOS which support this. There is no real down side to tweaking the iso images in this way.

I like the idea, but there does appear to be one potential downside. From the syslinux isolinux.txt documentation:

"The ISO 9660 filesystem is encapsulated in a partition (which starts at offset zero, which may confuse some systems.)"

How many different systems and firmware has this been tested on?

I think it is a worthwhile patch, but we should be aware of the above in case a regression is reported. In such an event, it seems a NO_ISO_HYBRID flag could be set by the machine.conf to revert to the older behavior.

--
Darren

Quoted 26 lines

[YOCTO #1763 partial]

---

meta/classes/bootimg.bbclass +2 -0
index f4981d8..370b378 100644
@@ -103,6 +103,8 @@ build_iso() {
 			-r ${ISODIR}
 	fi
 
+	isohybrid ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.iso
+
 	cd ${DEPLOY_DIR_IMAGE}
 	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso
 	ln -s ${IMAGE_NAME}.iso ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#2 lore raw
Quoted 6 lines · Darren Hart

How many different systems and firmware has this been tested on?

I think it is a worthwhile patch, but we should be aware of the above in case a regression is reported. In such an event, it seems a NO_ISO_HYBRID flag could be set by the machine.conf to revert to the older behavior.

and please, do it in 1.3 only.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#3 lore raw
In reply to Darren Hart
Quoted 14 lines · Darren Hart
Quoted 5 lines · Richard Purdie

From: Damien Lespiau <[email protected]>

This allows iso images to be written to usb keys and booted on systems which have a BIOS which support this. There is no real down side to tweaking the iso images in this way.

I like the idea, but there does appear to be one potential downside. From the syslinux isolinux.txt documentation:

"The ISO 9660 filesystem is encapsulated in a partition (which starts at offset zero, which may confuse some systems.)"

Quoted 6 lines

How many different systems and firmware has this been tested on?

I think it is a worthwhile patch, but we should be aware of the above in case a regression is reported. In such an event, it seems a NO_ISO_HYBRID flag could be set by the machine.conf to revert to the older behavior.

Agreed, I think we should try this and see if there are any problems reported. I tested a few machines here and it seemed to work on most of them but this was with a USB key, not a CD image. This is probably our more common use case though.

Cheers,

Richard