Skip to contentSkip to conversation

Fixes to cifs_show_options

PATCH In review Sachin Prabhu 2 participants 2 messages Apr 24, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fixes to cifs_show_options

/proc/mounts does not show the mount options backupuid/backupgid for cifs shares mounted with those options.

While adding the backupuid/backupgid options to cifs_show_options, I noticed that we incorrectly use %d instead of %u for the unsigned variables used to denote uid, gid, rsize and wsize. This is fixed by the second patch

Sachin Prabhu (2):
CIFS: Show backupuid/gid in /proc/mounts
Use correct conversion specifiers in cifs_show_options

 fs/cifs/cifsfs.c  |   12 ++++++++----
 fs/cifs/connect.c |   12 ++++++------
 2 files changed, 14 insertions(+), 10 deletions(-)
Signature · 1 line
1.7.7.6
#1 lore raw

merged

Quoted 20 lines · Sachin Prabhu

/proc/mounts does not show the mount options backupuid/backupgid for cifs shares mounted with those options.

While adding the backupuid/backupgid options to cifs_show_options, I noticed that we incorrectly use %d instead of %u for the unsigned variables used to denote uid, gid, rsize and wsize. This is fixed by the second patch

Sachin Prabhu (2):
 CIFS: Show backupuid/gid in /proc/mounts
 Use correct conversion specifiers in cifs_show_options

 fs/cifs/cifsfs.c  |   12 ++++++++----
 fs/cifs/connect.c |   12 ++++++------

 2 files changed, 14 insertions(+), 10 deletions(-)

--
1.7.7.6

Signature · 3 lines
Thanks,

Steve