mfd/tps65910: fix section mismatch in linux-next
Subsystems (2)
PATCH 1/1 mfd/tps65910: fix section mismatch in linux-next
tps65910_i2c_probe() calls tps65910_sleepinit() which is annnotated __init.
--- drivers/mfd/tps65910.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/tps65910.c +1 -1
@@ -150,7 +150,7 @@ err_sleep_init: } -static int tps65910_i2c_probe (struct i2c_client *i2c, +static int __init tps65910_i2c_probe (struct i2c_client *i2c,const struct i2c_device_id *id) {struct tps65910 *tps65910;
Signature · 1 line
1.7.7.6
drivers/mfd/tps65910.c err_sleep_init: · line 153
Quoted 4 lines · Gerard Snitselaar
tps65910_i2c_probe()callstps65910_sleepinit()which is annnotated__init.drivers/mfd/tps65910.c +1
-1-static int tps65910_i2c_probe(struct i2c_client *i2c, +static int __init tps65910_i2c_probe(struct i2c_client *i2c,
Shouldn't this be __devinit not __init?
Quoted 4 lines · Gerard Snitselaar
tps65910_i2c_probe()callstps65910_sleepinit()which is annnotated__init.Signed-off-by Gerard Snitselaar<[email protected]>---
drivers/mfd/tps65910.c err_sleep_init: · line 154
Quoted 3 lines · Gerard Snitselaar
drivers/mfd/tps65910.c +1
-1-static int tps65910_i2c_probe (struct i2c_client *i2c, +static int __init tps65910_i2c_probe (struct i2c_client *i2c,const struct i2c_device_id *id)
I sent a separate fix for this earlier on - __init is the wrong annotation here, a device init function should be marked __devinit.
Quoted 8 lines · Mark Brown
drivers/mfd/tps65910.c err_sleep_init: · line 154
Quoted 3 lines · Gerard Snitselaar
drivers/mfd/tps65910.c +1
-1-static int tps65910_i2c_probe (struct i2c_client *i2c, +static int __init tps65910_i2c_probe (struct i2c_client *i2c,const struct i2c_device_id *id)I sent a separate fix for this earlier on -
__initis the wrong annotation here, a device init function should be marked__devinit.
I missed your patch when I did a search initially. Does it also change the annotation of tps65910_sleepinit() to __devinit ? If all devices are supposed to have their init functions annotated __devinit is the comment in correct in init.h which says the __dev* annotations are used for HOTPLUG? Is this power management chip hotpluggable?