Flexible proportions
Subsystems (2)
v2 cover Flexible proportions
Hello,
so I got back to my idea of providing code for computing event proportions
where aging period is not dependent on the number of events happening (so that aging works well both with fast storage and slow USB sticks in the same system).
The basic idea is that we compute proportions as:p_j = (\Sum_{i>=0} x_{i,j}/2^{i+1}) / (\Sum_{i>=0} x_i/2^{i+1})
Where x_{i,j} is j's number of events in i-th last time period and x_i is
total number of events in i-th last time period.
Note that when x_i's are all the same (as is the case with current
proportion code), this expression simplifies to the expression defining current proportions which is:p_j = \Sum_{i>=0} x_{i,j}/2^{i+1} / t
where t is the lenght of the aging period.
In fact, if we are in the middle of the period, the proportion computed by
the current code is:p_j = (x_0 + \Sum_{i>=1} x_{i,j}/2^{i+1}) / (t' + t)
where t' is total number of events in the running period and t is the lenght
of the aging period. So there is event more similarity.
Similarly as with current proportion code, it is simple to compute update
proportion after several periods have elapsed. For each proportion we store the numerator of our fraction and the number of period when the proportion was last updated. In global proportion structure we compute the denominator of the fraction which is the same for all event types. So catch up with missed periods boils down to shifting the numerator by the number of missed periods and that's it. For more details, please see the code.
I've also run a few tests (I've created a userspace wrapper to allow me to
run proportion code in userpace and arbitrarily generate events for it) to compare the behavior of old and new code. You can see them at
http://beta.suse.com/private/jack/flex_proportions/ In all the tests new code showed faster convergence to current event proportions (I tried to realistically set period_shift for fixed proportions). Also in the last test we see that if period_shift is decreased, then current proportions become more sensitive to short term fluctuations in event rate so just decreasing period_shift isn't a good solution to slower convergence. If anyone has other idea what to try, I can do that - it should be simple enough to implement in my testing tool.
So my plan, if people are happy with the new proportion code, would be to
switch at least bdi writeout proportion to the new code. I can also check other users to see whether it would make sense for them to switch. So what do people think?
Honza
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
RFC PATCH v2 1/1 lib: Proportions with flexible period
Implement code computing proportions of events of different type (like code in lib/proportions.c) but allowing periods to have different lengths. This allows us to have aging periods of fixed wallclock time which gives better proportion estimates given the hugely varying throughput of different devices - previous measuring of aging period by number of events has the problem that a reasonable period length for a system with low-end USB stick is not a reasonable period length for a system with high-end storage array resulting either in too slow proportion updates or too fluctuating proportion updates.
--- include/linux/flex_proportions.h | 89 ++++++++++++++++ lib/flex_proportions.c | 218 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 307 insertions(+), 0 deletions(-) create mode 100644 include/linux/flex_proportions.h create mode 100644 lib/flex_proportions.c
include/linux/flex_proportions.h new file +89 -0
@@ -0,0 +1,89 @@ +/* +* Floating proportions with flexible aging period +* +* Copyright (C) 2011, SUSE, Jan Kara <[email protected]> +*/ + +#ifndef _LINUX_FLEX_PROPORTIONS_H +#define _LINUX_FLEX_PROPORTIONS_H + +#include <linux/percpu_counter.h> +#include <linux/spinlock.h> +#include <linux/seqlock.h> + +/* +* ---- Global proportion definitions ---- +*/ +struct fprop_global { +/* Number of events in the current period */ +struct percpu_counter events; +/* Current period */ +unsigned int period; +/* Synchronization with period transitions */ +seqcount_t sequence; +}; + +int fprop_global_init (struct fprop_global *p); +void fprop_global_destroy (struct fprop_global *p); +void fprop_new_period (struct fprop_global *p); + +/* +* ---- SINGLE ---- +*/ +struct fprop_local_single { +/* the local events counter */ +unsigned long events; +/* Period in which we last updated events */ +unsigned int period; +raw_spinlock_t lock;/* Protect period and numerator */ +}; + +#define INIT_FPROP_LOCAL_SINGLE (name) \ +{ .lock = __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ +} + +int fprop_local_init_single (struct fprop_local_single *pl); +void __fprop_inc_single (struct fprop_global *p,struct fprop_local_single *pl); +void fprop_fraction_single (struct fprop_global *p, +struct fprop_local_single *pl,unsigned long *numerator, +unsigned long *denominator); + +static inline +void fprop_inc_single (struct fprop_global *p,struct fprop_local_single *pl) +{ +unsigned long flags; + +local_irq_save (flags); +__fprop_inc_single (p, pl); +local_irq_restore (flags); +} + +/* +* ---- PERCPU ---- +*/ +struct fprop_local_percpu { +/* the local events counter */ +struct percpu_counter events; +/* Period in which we last updated events */ +unsigned int period; +raw_spinlock_t lock;/* Protect period and numerator */ +}; + +int fprop_local_init_percpu (struct fprop_local_percpu *pl); +void fprop_local_destroy_percpu (struct fprop_local_percpu *pl); +void __fprop_inc_percpu (struct fprop_global *p,struct fprop_local_percpu *pl); +void fprop_fraction_percpu (struct fprop_global *p, +struct fprop_local_percpu *pl,unsigned long *numerator, +unsigned long *denominator); + +static inline +void fprop_inc_percpu (struct fprop_global *p,struct fprop_local_percpu *pl) +{ +unsigned long flags; + +local_irq_save (flags); +__fprop_inc_percpu (p, pl); +local_irq_restore (flags); +} + +#endif
lib/flex_proportions.c new file +218 -0
218 lines not on this page · raw message
Signature · 8 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH RFC v2] lib: Proportions with flexible period
Quoted 8 lines · Jan Kara
Implement code computing proportions of events of different type (like code in
lib/proportions.c) but allowing periods to have different lengths. This allows us to have aging periods of fixed wallclock time which gives better proportion estimates given the hugely varying throughput of different devices - previous measuring of aging period by number of events has the problem that a reasonable period length for a system with low-end USB stick is not a reasonable period length for a system with high-end storage array resulting either in too slow proportion updates or too fluctuating proportion updates.
OK, seems sound. Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi Jan,
Quoted 4 lines
So my plan, if people are happy with the new proportion code, would be to
switch at least bdi writeout proportion to the new code. I can also check other users to see whether it would make sense for them to switch. So what do people think?
When you get ready with the full patchset, I would be very interested in watching how it performs in the various JBOD tests :-)
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>