ASoC: tlv312aic23: unbreak resume
Subsystems (3)
PATCH 1/1 ASoC: tlv312aic23: unbreak resume
* commit f9dfbf9 "ASoC: tlv320aic23: convert to soc-cache" leads to a bug preventing resumeof the codec as regmap expects a 9 bits data register but 0xFFFF is passed in tlv320aic23_set_bias_level and this values gets cached preventing any write to the TLV320AIC23_PWR register as the final value produced by regmap is (register << 9) | value
* this patch solves the problem by only working on the 9 bits the register contains.
--- sound/soc/codecs/tlv320aic23.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/tlv320aic23.c +2 -2
@@ -472,7 +472,7 @@ static int tlv320aic23_set_dai_sysclk(struct snd_soc_dai *codec_dai,static int tlv320aic23_set_bias_level (struct snd_soc_codec *codec,enum snd_soc_bias_level level) { -u16 reg =snd_soc_read (codec,TLV320AIC23_PWR ) &0xff7f ; +u16 reg =snd_soc_read (codec,TLV320AIC23_PWR ) &0x17f ;switch (level) {case SND_SOC_BIAS_ON :
@@ -491,7 +491,7 @@ static int tlv320aic23_set_bias_level(struct snd_soc_codec *codec,case SND_SOC_BIAS_OFF :/* everything off, dac mute, inactive */ snd_soc_write (codec,TLV320AIC23_ACTIVE ,0x0 ); -snd_soc_write (codec,TLV320AIC23_PWR ,0xffff ); +snd_soc_write (codec,TLV320AIC23_PWR ,0x1ff );break ; } codec->dapm.bias_level = level;
Signature · 6 lines
1.7.7.6 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
AppliedQuoted 5 lines · Eric Bénard
* commit f9dfbf9 "ASoC: tlv320aic23: convert to soc-cache" leads to a bug preventing resumeof the codec as regmap expects a 9 bits data register but
0xFFFFis passed intlv320aic23_set_bias_leveland this values gets cached preventing any write to theTLV320AIC23_PWRregister as the final value produced by regmap is (register << 9) | value
Applied, thanks.