x86: kernel/dumpstack.c simple_strtoul cleanup

PATCH New Shuah Khan 1 participant 1 message May 2, 2012

Subsystems (2)

x86 x86 stack unwinding

lore

Share & tools

lore

Shuah Khan

author

2012-05-02 22:50 UTC #0 lore raw

PATCH 1/1 x86: kernel/dumpstack.c simple_strtoul cleanup

Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c to call kstrtoul() instead of calling obsoleted simple_strtoul().

Quoted 1 line

From 2988db2b5cef39ee908a0165732a42c12897ccef Mon Sep 17 00:00:00 2001

From: Shuah Khan <[email protected]>
Date: Wed, 2 May 2012 12:59:17 -0600
Subject: [PATCH] x86: kernel/dumpstack.c simple_strtoul cleanup

Signed-off-by Shuah Khan <[email protected]>

---
 arch/x86/kernel/dumpstack.c |   21 +++++++++++++++++++--
 1 files changed, 19 insertions(+), 2 deletions(-)

arch/x86/kernel/dumpstack.c +19 -2

index 1b81839..b154f6d 100644
@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)
 
 static int __init kstack_setup(char *s)
 {
+	ssize_t ret;
+	unsigned long val;
+
 	if (!s)
 		return -EINVAL;
-	kstack_depth_to_print = simple_strtoul(s, NULL, 0);
+
+	ret = kstrtoul(s, 0, &val);
+	if (ret)
+		return ret;
+	kstack_depth_to_print = val;
 	return 0;
 }
 early_param("kstack", kstack_setup);
 
 static int __init code_bytes_setup(char *s)
 {
-	code_bytes = simple_strtoul(s, NULL, 0);
+	ssize_t ret;
+	unsigned long val;
+
+	if (!s)
+		return -EINVAL;
+
+	ret = kstrtoul(s, 0, &val);
+	if (ret)
+		return ret;
+
+	code_bytes = val;
 	if (code_bytes > 8192)
 		code_bytes = 8192;

Signature · 1 line

1.7.5.4