Skip to contentSkip to conversation

Remove two unused functions

PATCH In review David Sommerseth 2 participants 2 messages May 3, 2012 – Jun 1, 2012

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 Remove two unused functions

From: David Sommerseth <[email protected]...>

Both is_persist_option() and is_stateful_restart() functions where never used anywhere in the code. Remove them.

Signed-off-by David Sommerseth <[email protected]...>
---
 src/openvpn/options.c |   16 ----------------
 src/openvpn/options.h |    3 ---
 2 files changed, 0 insertions(+), 19 deletions(-)
src/openvpn/options.c +0 -16
index 7769625..c182d12 100644
@@ -1047,22 +1047,6 @@ string_substitute (const char *src, int from, int to, struct gc_arena *gc)
   return ret;
 }
 
-bool
-is_persist_option (const struct options *o)
-{
-  return o->persist_tun
-      || o->persist_key
-      || o->persist_local_ip
-      || o->persist_remote_ip
-    ;
-}
-
-bool
-is_stateful_restart (const struct options *o)
-{
-  return is_persist_option (o) || connection_list_defined (o);
-}
-
 #ifdef ENABLE_SSL
 static uint8_t *
 parse_hash_fingerprint(const char *str, int nbytes, int msglevel, struct gc_arena *gc)
src/openvpn/options.h +0 -3
index 1be3dfa..cc3e47a 100644
@@ -749,9 +749,6 @@ bool apply_push_options (struct options *options,
 			 unsigned int *option_types_found,
 			 struct env_set *es);
 
-bool is_persist_option (const struct options *o);
-bool is_stateful_restart (const struct options *o);
-
 void options_detach (struct options *o);
 
 void options_server_import (struct options *o,
Signature · 1 line
1.7.4.4
#1 lore raw
Quoted 10 lines · David Sommerseth

From: David Sommerseth <[email protected]...>

Both is_persist_option() and is_stateful_restart() functions where never used anywhere in the code. Remove them.

Signed-off-by David Sommerseth <[email protected]...>
---
 src/openvpn/options.c |   16 ----------------
 src/openvpn/options.h |    3 ---
 2 files changed, 0 insertions(+), 19 deletions(-)

ACKed by Gert in IRC during the meeting on Thursday. Applied to master branch.

commit e8298885350131ce453da54a1b07495253ee1508

Author: David Sommerseth <[email protected]...>
Date:   Thu May 3 11:10:40 2012 +0200
    Remove two unused functions
    
    Signed-off-by: David Sommerseth <[email protected]...>
    Acked-by: Gert Doering <[email protected]...>
    Message-Id: [email protected]...
    URL: http://article.gmane.org/gmane.network.openvpn.devel/6402

kind regards,

David Sommerseth