IIO: industrialio-core: Checking NULL instead of IS_ERR for debugfs_create_dir()

PATCH New Axel Lin 1 participant 1 message May 3, 2012 IIO

lore

Share & tools

lore

Axel Lin

author

2012-05-03 14:56 UTC #0 lore raw

PATCH 1/1 IIO: industrialio-core: Checking NULL instead of IS_ERR for debugfs_create_dir()

If defined CONFIG_DEBUG_FS, debugfs_create_dir returns NULL on failure.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/iio/industrialio-core.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

drivers/iio/industrialio-core.c +1 -4

index 72e33b8..c74412b 100644
@@ -235,15 +235,12 @@ static int iio_device_register_debugfs(struct iio_dev *indio_dev)
 	if (indio_dev->info->debugfs_reg_access == NULL)
 		return 0;
 
-	if (IS_ERR(iio_debugfs_dentry))
+	if (!iio_debugfs_dentry)
 		return 0;
 
 	indio_dev->debugfs_dentry =
 		debugfs_create_dir(dev_name(&indio_dev->dev),
 				   iio_debugfs_dentry);
-	if (IS_ERR(indio_dev->debugfs_dentry))
-		return PTR_ERR(indio_dev->debugfs_dentry);
-
 	if (indio_dev->debugfs_dentry == NULL) {
 		dev_warn(indio_dev->dev.parent,
 			 "Failed to create debugfs directory\n");

Signature · 1 line

1.7.5.4