Skip to contentSkip to conversation

libmodbus: ported recipe from classic and updated

PATCH Superseded Andrea Galbusera 4 participants 7 messages May 4, 2012 – May 15, 2012

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libmodbus: ported recipe from classic and updated

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* also provide an _git version with up-to-date SRCREV and DEFAULT_PREFERENCE = "-1"
* common part factorized as libmodbus.inc

---
 meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
 .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
 3 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +13 -0
new file mode 100644
index 0000000..8e0e011
@@ -0,0 +1,13 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+PRIORITY = "optional"
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+INC_PR = "r0"
+
+inherit autotools pkgconfig
meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +8 -0
new file mode 100644
index 0000000..7a99f72
@@ -0,0 +1,8 @@
+require libmodbus.inc
+
+PR = "${INC_PR}.0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
meta-oe/recipes-extended/libmodbus/libmodbus_git.bb new file +13 -0
new file mode 100644
index 0000000..793a9d6
@@ -0,0 +1,13 @@
+require libmodbus.inc
+
+SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
+
+PV = "3.0.2+gitr${SRCPV}"
+
+PR = "${INC_PR}.0"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
+S = "${WORKDIR}/git"
+
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 4 lines · Andrea Galbusera

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* also provide an _git version with up-to-date SRCREV and DEFAULT_PREFERENCE = "-1"

You should always prefix the subject line with layername e.g. [meta-oe]... so you get appropriate maintainers attention

Do we really need the git version ? if not then drop it.

Quoted 18 lines

* common part factorized as libmodbus.inc

---
 meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++ .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++ .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++

 3 files changed, 34 insertions(+), 0 deletions(-)

 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb

meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +0 -0
new file mode 100644
index 0000000..8e0e011

meta-oe/recipes-extended/libmodbus/libmodbus.inc line 7

Quoted 7 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +7 -0
@@ -0,0 +1,13 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+PRIORITY = "optional"

PRIORITY is no longer used drop it.

meta-oe/recipes-extended/libmodbus/libmodbus.inc line 11

Quoted 4 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +4 -0
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+INC_PR = "r0"

if you are just having 1 recipe i.e. dropping git recipe then change that to PR

Quoted 43 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +2 -0
+
+inherit autotools pkgconfig
meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +8 -0
new file mode 100644
index 0000000..7a99f72
@@ -0,0 +1,8 @@
+require libmodbus.inc
+
+PR = "${INC_PR}.0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
meta-oe/recipes-extended/libmodbus/libmodbus_git.bb new file +13 -1
new file mode 100644
index 0000000..793a9d6
@@ -0,0 +1,13 @@
+require libmodbus.inc
+
+SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
+
+PV = "3.0.2+gitr${SRCPV}"
+
+PR = "${INC_PR}.0"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
+S = "${WORKDIR}/git"
+
--

1.7.5.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#2 lore raw

Hi Khem and Martin,

Quoted 8 lines · Khem Raj
Quoted 4 lines · Andrea Galbusera

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* also provide an _git version with up-to-date SRCREV and DEFAULT_PREFERENCE = "-1"

You should always prefix the subject line with layername e.g. [meta-oe]... so you get appropriate maintainers attention

Ok!

Quoted 2 lines

Do we really need the git version ? if not then drop it.

Thank you for reviewing. I agree with you: the stable release should be enough. git version was included only because it was there in classic.
I'll update and resend as v2.

Quoted 12 lines
Quoted 12 lines

* common part factorized as libmodbus.inc

---
 meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++ .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++ .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++

 3 files changed, 34 insertions(+), 0 deletions(-)

 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb

Quoted 15 lines

meta-oe/recipes-extended/libmodbus/libmodbus.inc line 7

Quoted 13 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +7 -0
new file mode 100644
index 0000000..8e0e011
@@ -0,0 +1,13 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+PRIORITY = "optional"

PRIORITY is no longer used drop it.

Good to know!

Quoted 56 lines

meta-oe/recipes-extended/libmodbus/libmodbus.inc line 11

Quoted 4 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +4 -0
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+INC_PR = "r0"

if you are just having 1 recipe i.e. dropping git recipe then change that to PR

Quoted 39 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +2 -0
+
+inherit autotools pkgconfig
meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +8 -0
new file mode 100644
index 0000000..7a99f72
@@ -0,0 +1,8 @@
+require libmodbus.inc
+
+PR = "${INC_PR}.0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
meta-oe/recipes-extended/libmodbus/libmodbus_git.bb new file +13 -1
new file mode 100644
index 0000000..793a9d6
@@ -0,0 +1,13 @@
+require libmodbus.inc
+
+SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
+
+PV = "3.0.2+gitr${SRCPV}"
+
+PR = "${INC_PR}.0"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
+S = "${WORKDIR}/git"
+
--

1.7.5.4

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw
In reply to Andrea Galbusera
Quoted 22 lines · Andrea Galbusera

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* also provide an _git version with up-to-date SRCREV and DEFAULT_PREFERENCE = "-1"
* common part factorized as libmodbus.inc

---
 meta-oe/recipes-extended/libmodbus/libmodbus.inc   |   13 +++++++++++++
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |    8 ++++++++
 .../recipes-extended/libmodbus/libmodbus_git.bb    |   13 +++++++++++++
 3 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus.inc
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_git.bb
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +0 -0
new file mode 100644
index 0000000..8e0e011

meta-oe/recipes-extended/libmodbus/libmodbus.inc line 7

Quoted 7 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +7 -0
@@ -0,0 +1,13 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+PRIORITY = "optional"

you can drop this field too.

Quoted 47 lines
meta-oe/recipes-extended/libmodbus/libmodbus.inc new file +6 -0
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+INC_PR = "r0"
+
+inherit autotools pkgconfig
meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +8 -0
new file mode 100644
index 0000000..7a99f72
@@ -0,0 +1,8 @@
+require libmodbus.inc
+
+PR = "${INC_PR}.0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
meta-oe/recipes-extended/libmodbus/libmodbus_git.bb new file +13 -0
new file mode 100644
index 0000000..793a9d6
@@ -0,0 +1,13 @@
+require libmodbus.inc
+
+SRCREV = "23dd803f3f2b7be668408fa938e8d665249b4fba"
+
+PV = "3.0.2+gitr${SRCPV}"
+
+PR = "${INC_PR}.0"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://github.com/stephane/libmodbus;branch=master;protocol=git"
+S = "${WORKDIR}/git"
+
Signature · 7 lines
1.7.5.4


_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

PATCH v2 1/1 libmodbus: ported recipe from classic and updated

In reply to Andrea Galbusera

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* v2 drops git version of recipe
* v2 drops no longer used PRIORITY

---
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +18 -0
new file mode 100644
index 0000000..5926bc4
@@ -0,0 +1,18 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+PR = "r0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+inherit autotools pkgconfig
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
Signature · 1 line
1.7.5.4
#5 lore raw

Hi,

Quoted 36 lines · Andrea Galbusera

* based on recipe by Radoslav Kolev which was in classic
* updated to latest released version 3.0.2
* v2 drops git version of recipe
* v2 drops no longer used PRIORITY

---
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   18 ++++++++++++++++++

 1 files changed, 18 insertions(+), 0 deletions(-)

 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb

meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file +18 -1
new file mode 100644
index 0000000..5926bc4
@@ -0,0 +1,18 @@
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+PR = "r0"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+inherit autotools pkgconfig
+
+SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
+SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
--
Quoted 2 lines

1.7.5.4

Any comment on this patch respin?
Regards

#6 lore raw
In reply to Andrea Galbusera

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 05-05-12 17:51, Andrea Galbusera schreef:

Quoted 10 lines

* based on recipe by Radoslav Kolev which was in classic * updated to latest released version 3.0.2 * v2 drops git version of recipe * v2 drops no longer used PRIORITY

.../recipes-extended/libmodbus/libmodbus_3.0.2.bb | 18
++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb

(quoted diff) +0 -0
Quoted 10 lines

b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb new file mode 100644 index 0000000..5926bc4 --- /dev/null +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb @@ -0,0 +1,18 @@ +SUMMARY = "A Modbus library" +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \ +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \ +QNX and Windows." +HOMEPAGE = "http://www.libmodbus.org/" +SECTION = "libs" + +LICENSE = "LGPLv2.1+" +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c" + +PR = "r0"

Drop that
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQIcBAEBAgAGBQJPsgoyAAoJEHZqAkdh1vT6jHsP/3FzoPMuoKnCpE8DS8r/7Tj6 iE126Y0KV7O8qb0Myr9EeUAFhuiuwp2RXJlznrMHVqNVOJa46dvAnmbcq6v/r/xR QQQGuRnqLOJwSJpWuphxRqbUHKFIAQYePSuIdzqAydJxEH017yz+btAryoxHQd/g He78sRYvpFkavoFhjBpcFXDYcW9JZFHc7iFKThv3qDaWNbbabd2p4McM8x1O0FjJ pybhuLaAbsae5pB2BWItncf60IEY1BiKhjraJ6658XSLNZf8oEt8XOh3BzNRMTSC AFwWZpvfIiz8h6IG7nYv5Cfnrw59mYoH+c5hLr8tRNpCsUSYr95uQc+oa1Y6ldrN 24bsgkQv4VPwH7yRVDruZSb3FJna99pP9KSmTzvOYCeJio/vIq1LyskCCSyiX09i iB/P0QFubAH67k3m2VNrbFB+YZE/VSe7KJDAPbONKduaNKQQCSapAngi+4TWlsGR 5lR/e+LsPk4YpqWcm97L/beJfSLpwlNkhWrkGYjYtkxOztkvO7Tj1OoLiYMoFnIz rW+FnLNk4pmhM6fD76yNpn9YtJCOCPIvNvTkKcfkRDR6UPK3Jvy9nWvNlgZvqnPr F4PQ5mcqdR/3l9TM9iAIA6zX4tiIOMBef2Mxzk3z0MmGtIM6+FcZFGAin39ggA+z dZyJP6aXgvnQehZhhAU4
=YKDQ
-----END PGP SIGNATURE-----