Protection against ever-more-talented fools...
Time for some shell trivia!
Trivia point: PATH=:/usr/bin and PATH=.:/usr/bin are equivalent. Trivia point: So are PATH=/bin::/usr/bin and PATH=/bin:.:/usr/bin Trivia point: People love to write stuff like:
PATH=$(THAT_DIRECTORY):$PATH
Trivia point: The shell expands undefined variables to empty strings.
Which is to say:
meta/classes/sanity.bbclass +3 -2
@@ -298,8 +298,9 @@ def check_sanity(e): if not check_app_exists("qemu-arm", e.data): messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH" - if "." in data.getVar('PATH', e.data, True).split(":"): - messages = messages + "PATH contains '.' which will break the build, please remove this" + paths = data.getVar('PATH', e.data, True).split(":") + if "." in paths or "" in paths: + messages = messages + "PATH contains '.' or '', which will break the build, please remove this." if data.getVar('TARGET_ARCH', e.data, True) == "arm": # This path is no longer user-readable in modern (very recent) Linux
Signature · 1 line
Listen, get this. Nobody with a good compiler needs to be justified.
Quoted 9 lines · Peter Seebach
Time for some shell trivia!
Trivia point: PATH=:/usr/bin and PATH=.:/usr/bin are equivalent. Trivia point: So are PATH=/bin::/usr/bin and PATH=/bin:.:/usr/bin Trivia point: People love to write stuff like:PATH=$(THAT_DIRECTORY):$PATH
Trivia point: The shell expands undefined variables to empty strings.Which is to say:
I like the patch and I can live with the commit message but could we have the right subject line and a signed-off-by please? :)
Cheers,
Richard
Quoted 2 lines · On Wed, 9 May 2012 20:49:23 +0100 Richard Purdie…
I like the patch and I can live with the commit message but could we have the right subject line and a signed-off-by please? :)
Heh. I hadn't actually intended this as a pull request, just commentary, but I can do a proper pull request with a meaningful subject, commit message, etc.
-s
Signature · 1 line
Listen, get this. Nobody with a good compiler needs to be justified.