ip(6)tables-restore: make sure argv is NULL terminated
Florian Westphal
maintainerPATCH 1/1 ip(6)tables-restore: make sure argv is NULL terminated
Else, argv[argc] may point to free'd memory.
Some extensions, e.g. rateest, may fail to parse valid input because argv[optind] (with optind == argc) is not NULL.
Signed-off-by Florian Westphal <[email protected]>
--- iptables/ip6tables-restore.c | 2 +- iptables/iptables-restore.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
iptables/ip6tables-restore.c +1 -1
@@ -98,7 +98,7 @@ static int add_argv(char *what) {DEBUGP ("add_argv: %s\n" , what);if (what && newargc +1 <ARRAY_SIZE (newargv)) { newargv[newargc] =strdup (what); - newargc++; + newargv[++newargc] =NULL ;return 1 ; }else { xtables_error(PARAMETER_PROBLEM,
iptables/iptables-restore.c +1 -1
@@ -97,7 +97,7 @@ static int add_argv(char *what) {DEBUGP ("add_argv: %s\n" , what);if (what && newargc +1 <ARRAY_SIZE (newargv)) { newargv[newargc] =strdup (what); - newargc++; + newargv[++newargc] =NULL ;return 1 ; }else { xtables_error(PARAMETER_PROBLEM,
Signature · 1 line
1.7.3.4
Quoted 4 lines · Florian Westphal
Else, argv[argc] may point to free'd memory.
Some extensions, e.g. rateest, may fail to parse valid input because argv[optind] (with optind == argc) is not NULL.
Applied, thanks Florian.