netfilter: nf_ct_tcp: extend log message for invalid ignored packets
Subsystems (2)
[email protected]
maintainerPATCH 1/1 netfilter: nf_ct_tcp: extend log message for invalid ignored packets
From: Pablo Neira Ayuso <[email protected]>
Extend log message if packets are ignored to include the TCP state, ie. replace:
[ 3968.070196] nf_ct_tcp: invalid packet ignored IN= OUT= SRC=...
by:
[ 3968.070196] nf_ct_tcp: invalid packet ignored in state ESTABLISHED IN= OUT= SRC=...
This information is useful to know in what state we were while ignoring the packet.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nf_conntrack_proto_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/netfilter/nf_conntrack_proto_tcp.c +2 -1
@@ -952,7 +952,8 @@ static int tcp_packet(struct nf_conn *ct,spin_unlock_bh (&ct->lock);if (LOG_INVALID (net,IPPROTO_TCP ))nf_log_packet (pf,0 , skb,NULL ,NULL ,NULL , -"nf_ct_tcp: invalid packet ignored " ); +"nf_ct_tcp: invalid packet ignored in " +"state %s " , tcp_conntrack_names[old_state]);return NF_ACCEPT ;case TCP_CONNTRACK_MAX :/* Invalid packet */
Signature · 1 line
1.7.10
Quoted 36 lines · On Mon, 14 May 2012, [email protected] wrote:
From: Pablo Neira Ayuso <[email protected]>
Extend log message if packets are ignored to include the TCP state, ie. replace:
[ 3968.070196] nf_ct_tcp: invalid packet ignored IN= OUT= SRC=...by:
[ 3968.070196] nf_ct_tcp: invalid packet ignored in state ESTABLISHED IN= OUT= SRC=...This information is useful to know in what state we were while ignoring the packet.
Signed-off-by Pablo Neira Ayuso <[email protected]>--- net/netfilter/nf_conntrack_proto_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/netfilter/nf_conntrack_proto_tcp.c +2
-1@@ -952,7 +952,8 @@ static int tcp_packet(struct nf_conn *ct,spin_unlock_bh (&ct->lock);if (LOG_INVALID (net,IPPROTO_TCP ))nf_log_packet (pf,0 , skb,NULL ,NULL ,NULL , -"nf_ct_tcp: invalid packet ignored " ); +"nf_ct_tcp: invalid packet ignored in " +"state %s " , tcp_conntrack_names[old_state]);return NF_ACCEPT ;case TCP_CONNTRACK_MAX :/* Invalid packet */ Signature · 1 line
1.7.10
Acked-by Jozsef Kadlecsik <[email protected]>
Best regards,
Jozsef
-
E-mail : [email protected], [email protected] PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary