x86: kernel/dumpstack.c simple_strtoul cleanup
Subsystems (2)
PATCH RESEND 1/1 x86: kernel/dumpstack.c simple_strtoul cleanup
Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c to call kstrtoul() instead of calling obsoleted simple_strtoul().
Signed-off-by Shuah Khan <[email protected]>
--- arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++-- 1 files changed, 19 insertions(+), 2 deletions(-)
arch/x86/kernel/dumpstack.c +19 -2
@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)static int __init kstack_setup (char *s) { +ssize_t ret; +unsigned long val; +if (!s)return -EINVAL ; - kstack_depth_to_print =simple_strtoul (s,NULL ,0 ); + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + kstack_depth_to_print = val;return 0 ; }early_param ("kstack" , kstack_setup);static int __init code_bytes_setup (char *s) { - code_bytes =simple_strtoul (s,NULL ,0 ); +ssize_t ret; +unsigned long val; + +if (!s) +return -EINVAL ; + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + + code_bytes = val;if (code_bytes >8192 ) code_bytes =8192 ;
Signature · 1 line
1.7.5.4
Quoted 3 lines · Shuah Khan
Change
kstack_setup()andcode_bytes_setup()inkernel/dumpstack.cto callkstrtoul()instead of calling obsoletedsimple_strtoul().
How about this patch? Are you not interested in this type of cleanup patches? Looking for some feedback so I can spend my energies on something that would be worth while :)
-- Shuah
Quoted 46 lines
Signed-off-by Shuah Khan <[email protected]>--- arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++-- 1 files changed, 19 insertions(+), 2 deletions(-)arch/x86/kernel/dumpstack.c +19
-2@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)static int __init kstack_setup (char *s) { +ssize_t ret; +unsigned long val; +if (!s)return -EINVAL ; - kstack_depth_to_print =simple_strtoul (s,NULL ,0 ); + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + kstack_depth_to_print = val;return 0 ; }early_param ("kstack" , kstack_setup);static int __init code_bytes_setup (char *s) { - code_bytes =simple_strtoul (s,NULL ,0 ); +ssize_t ret; +unsigned long val; + +if (!s) +return -EINVAL ; + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + + code_bytes = val;if (code_bytes >8192 ) code_bytes =8192 ;
Commit-ID: 363f7ce3250aafdaab43011c7dc40158ea571e6b Gitweb: http://git.kernel.org/tip/363f7ce3250aafdaab43011c7dc40158ea571e6b Author: Shuah Khan <[email protected]> AuthorDate: Sun, 6 May 2012 11:58:04 -0600 Committer: H. Peter Anvin <[email protected]> CommitDate: Tue, 15 May 2012 15:36:42 -0700
x86: kernel/dumpstack.c simple_strtoul cleanup
Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c to call kstrtoul() instead of calling obsoleted simple_strtoul().
Signed-off-by Shuah Khan <[email protected]>
Signed-off-by H. Peter Anvin <[email protected]>
--- arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++-- 1 files changed, 19 insertions(+), 2 deletions(-)
arch/x86/kernel/dumpstack.c +19 -2
@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)static int __init kstack_setup (char *s) { +ssize_t ret; +unsigned long val; +if (!s)return -EINVAL ; - kstack_depth_to_print =simple_strtoul (s,NULL ,0 ); + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + kstack_depth_to_print = val;return 0 ; }early_param ("kstack" , kstack_setup);static int __init code_bytes_setup (char *s) { - code_bytes =simple_strtoul (s,NULL ,0 ); +ssize_t ret; +unsigned long val; + +if (!s) +return -EINVAL ; + + ret =kstrtoul (s,0 , &val); +if (ret) +return ret; + + code_bytes = val;if (code_bytes >8192 ) code_bytes =8192 ;