ARM: mxs: Let GPMI driver be built by default
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: mxs: Let GPMI driver be built by default
From: Fabio Estevam <[email protected]>
Let GPMI driver be built by default.
--- arch/arm/configs/mxs_defconfig | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/configs/mxs_defconfig +3 -0
@@ -58,6 +58,9 @@ CONFIG_CAN_FLEXCAN=m CONFIG_DEVTMPFS=y # CONFIG_FIRMWARE_IN_KERNEL is not set # CONFIG_BLK_DEV is not set +CONFIG_MTD=y +CONFIG_MTD_NAND=y +CONFIG_MTD_NAND_GPMI_NAND=y CONFIG_NETDEVICES=y CONFIG_NET_ETHERNET=y CONFIG_ENC28J60=y
Signature · 1 line
1.7.1
Shawn Guo
AppliedPATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Let GPMI driver be built by default.
Signed-off-by Fabio Estevam <[email protected]>
Queued for 3.6. Thanks.
Regards,
Shawn
Quoted 26 lines
--- arch/arm/configs/mxs_defconfig | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)arch/arm/configs/mxs_defconfig +3
-0@@ -58,6 +58,9 @@ CONFIG_CAN_FLEXCAN=m CONFIG_DEVTMPFS=y # CONFIG_FIRMWARE_IN_KERNEL is not set # CONFIG_BLK_DEV is not set +CONFIG_MTD=y +CONFIG_MTD_NAND=y +CONFIG_MTD_NAND_GPMI_NAND=y CONFIG_NETDEVICES=y CONFIG_NET_ETHERNET=y CONFIG_ENC28J60=ySignature · 7 lines
1.7.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Dear Shawn Guo,
Quoted 8 lines · Fabio Estevam
Quoted 5 lines
From: Fabio Estevam <[email protected]>
Let GPMI driver be built by default.
Signed-off-by Fabio Estevam <[email protected]>Queued for 3.6. Thanks.
Heh, if we get such trivial things in so late, the imx28 will be dead platform by the time it's supported mainline :-)
Quoted 19 lines
Regards,
ShawnQuoted 15 lines
---
arch/arm/configs/mxs_defconfig | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)(quoted diff) +0
-0b/arch/arm/configs/mxs_defconfig index 5406c23..6b86df7 100644
arch/arm/configs/mxs_defconfig +0
-0@@ -58,6 +58,9 @@ CONFIG_CAN_FLEXCAN=m CONFIG_DEVTMPFS=y # CONFIG_FIRMWARE_IN_KERNEL is not set # CONFIG_BLK_DEV is not set
Quoted 7 lines
Quoted 7 lines
arch/arm/configs/mxs_defconfig +3
-0+CONFIG_MTD=y +CONFIG_MTD_NAND=y +CONFIG_MTD_NAND_GPMI_NAND=y
CONFIG_NETDEVICES=y
CONFIG_NET_ETHERNET=y
CONFIG_ENC28J60=y
Best regards,
Marek Vasut
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Quoted 3 lines · Marek Vasut
Heh, if we get such trivial things in so late, the imx28 will be dead platform by the time it's supported mainline :-)
It's late for v3.5 merge window.
Regards,
Shawn
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Dear Shawn Guo,
Quoted 5 lines · Marek Vasut
Quoted 2 lines
Heh, if we get such trivial things in so late, the imx28 will be dead platform by the time it's supported mainline :-)
It's late for v3.5 merge window.
Well back in -around .30- it was still ok to add minor stuffs even if it was around rc1, they didn't break anything afterall. And this doesn't break anything (well, the gpmi driver is broken, so fix it ... if you get more people to use it, you'll have the fixes pouring your direction ... isn't that your objective, to make linux kernel even better than it is?)
Quoted 2 lines
Regards,
Shawn
Best regards,
Marek Vasut
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Quoted 6 lines · Marek Vasut
Dear Shawn Guo,
Quoted 4 lines · Marek Vasut
Quoted 2 lines
Heh, if we get such trivial things in so late, the imx28 will be dead platform by the time it's supported mainline :-)
Quoted 8 lines
Quoted 1 line
It's late for v3.5 merge window.
Well back in -around .30- it was still ok to add minor stuffs even if it was around rc1, they didn't break anything afterall. And this doesn't break anything (well, the gpmi driver is broken, so fix it ... if you get more people to use it, you'll have the fixes pouring your direction ... isn't that your objective, to make linux kernel even better than it is?)
The -rc should mostly be for bugfix. I also hope we can enable the driver in defconfig as soon as possible, but I won't do it until the driver is actually working with all known bugs fixed.
Signature · 2 lines
Regards, Shawn
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Dear Shawn Guo,
Quoted 16 lines · Marek Vasut
Quoted 6 lines
Dear Shawn Guo,
Quoted 4 lines · Marek Vasut
Quoted 2 lines
Heh, if we get such trivial things in so late, the imx28 will be dead platform by the time it's supported mainline :-)
Quoted 8 lines
Quoted 1 line
It's late for v3.5 merge window.
Well back in -around .30- it was still ok to add minor stuffs even if it was around rc1, they didn't break anything afterall. And this doesn't break anything (well, the gpmi driver is broken, so fix it ... if you get more people to use it, you'll have the fixes pouring your direction ... isn't that your objective, to make linux kernel even better than it is?)
Quoted 3 lines
The -rc should mostly be for bugfix. I also hope we can enable the driver in defconfig as soon as possible, but I won't do it until the driver is actually working with all known bugs fixed.
You've chosen the wrong approach then. There's always one remaining bug. But the more eyes on the code, the faster the bugs will be fixed.
Best regards,
Marek Vasut
PATCH 1/1 ARM: mxs: Let GPMI driver be built by default
Quoted 3 lines · Marek Vasut
You've chosen the wrong approach then. There's always one remaining bug. But the more eyes on the code, the faster the bugs will be fixed.
There's always one remaining bug which is to be found, not the bugs that we have known.
Anyway, as I've said it's not a bug fix. Thus it's not a candidate for v3.5-rc. It's simple as it is.
Regards,
Shawn