classes/sanity: remove broken TARGET_ARCH check

PATCH Applied Paul Eggleton 2 participants 2 messages May 28, 2012 – May 30, 2012

Share & tools

Paul Eggleton

author

2012-05-28 14:44 UTC #0 lore raw

PATCH 1/1 classes/sanity: remove broken TARGET_ARCH check

The variable name has been typo'd as TARGE_ARCH since it was introduced some time ago, so the check has never worked. Fixing the typo shows that the test is not quite functional, so let's just remove it:

http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/010613.html

Signed-off-by Paul Eggleton <[email protected]>

---
 meta/classes/sanity.bbclass |    4 ----
 1 file changed, 4 deletions(-)

meta/classes/sanity.bbclass +0 -4

index a2b45bc..8332105 100644
@@ -248,10 +248,6 @@ def check_sanity_validmachine(sanity_data):
     if sanity_data.getVar('TUNE_ARCH', True) == 'INVALID':
         messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n'
 
-    # Check TARGET_ARCH is set correctly
-    if sanity_data.getVar('TARGE_ARCH', False) == '${TUNE_ARCH}':
-        messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n'
-    
     # Check TARGET_OS is set
     if sanity_data.getVar('TARGET_OS', True) == 'INVALID':
         messages = messages + 'Please set TARGET_OS directly, or choose a MACHINE or DISTRO that does so.\n'

Signature · 1 line

1.7.9.5

Richard Purdie

Applied

2012-05-30 12:12 UTC #1 lore raw

Quoted 10 lines · Paul Eggleton

The variable name has been typo'd as TARGE_ARCH since it was introduced some time ago, so the check has never worked. Fixing the typo shows that the test is not quite functional, so let's just remove it:
http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/010613.html
Signed-off-by Paul Eggleton <[email protected]>
---
 meta/classes/sanity.bbclass |    4 ----
 1 file changed, 4 deletions(-)

Merged to master, thanks.

Richard