remove no longer use of pdflush interface
Subsystems (4)
PATCH 1/1 remove no longer use of pdflush interface
From: Wanpeng Li <[email protected]>
remove no longer use of pdflush interface nr_pdflush_threads.
--- Documentation/sysctl/vm.txt | 11 ----------- fs/fs-writeback.c | 5 ----- include/linux/writeback.h | 5 ----- kernel/sysctl.c | 7 ------- 4 files changed, 28 deletions(-)
Documentation/sysctl/vm.txt +0 -11
@@ -42,7 +42,6 @@ Currently, these files are in /proc/sys/vm: - mmap_min_addr - nr_hugepages - nr_overcommit_hugepages -- nr_pdflush_threads - nr_trim_pages (only if CONFIG_MMU=n) - numa_zonelist_order - oom_dump_tasks
@@ -426,16 +425,6 @@ See Documentation/vm/hugetlbpage.txt ============================================================== -nr_pdflush_threads - -The current number of pdflush threads. This value is read-only. -The value changes according to the number of dirty pages in the system. - -When necessary, additional pdflush threads are created, one per second, up to -nr_pdflush_threads_max. - -============================================================== - nr_trim_pages This is available only on NOMMU kernels.
fs/fs-writeback.c +0 -5
@@ -52,11 +52,6 @@ struct wb_writeback_work {struct completion *done;/* set if the caller waits */ }; -/* -* We don't actually have pdflush, but this one is exported though /proc... -*/ -int nr_pdflush_threads; -/** * writeback_in_progress - determine whether there is writeback in progress * @bdi: the device's backing_dev_info structure.
include/linux/writeback.h +0 -5
@@ -193,9 +193,4 @@ void tag_pages_for_writeback(struct address_space *mapping,void account_page_redirty (struct page *page); -/* pdflush.c */ -extern int nr_pdflush_threads;/* Global so it can be exported to sysctl -read-only. */ - -#endif /* WRITEBACK_H */
kernel/sysctl.c +0 -7
@@ -1095,13 +1095,6 @@ static struct ctl_table vm_table[] = { .extra1 = &zero, }, { - .procname = "nr_pdflush_threads", - .data = &nr_pdflush_threads, - .maxlen = sizeof nr_pdflush_threads, - .mode = 0444 /* read-only*/, - .proc_handler = proc_dointvec, - }, - { .procname = "swappiness", .data = &vm_swappiness, .maxlen = sizeof(vm_swappiness),
Signature · 1 line
1.7.9.5
Hi Wanpeng,
Quoted 3 lines · Wanpeng Li
From: Wanpeng Li <[email protected]>
remove no longer use of pdflush interface
nr_pdflush_threads.
The patch looks good in itself: the nr_pdflush_threads takes no effect for many of the recent kernels. But what's the normal process of interface removal? Shall we carry some warning printk for some time first or whatever?
Thanks,
Fengguang
Quoted 87 lines
Signed-off-by Wanpeng Li <[email protected]>--- Documentation/sysctl/vm.txt | 11 ----------- fs/fs-writeback.c | 5 ----- include/linux/writeback.h | 5 ----- kernel/sysctl.c | 7 ------- 4 files changed, 28 deletions(-)Documentation/sysctl/vm.txt +0
-11@@ -42,7 +42,6 @@ Currently, these files are in /proc/sys/vm: - mmap_min_addr - nr_hugepages - nr_overcommit_hugepages -- nr_pdflush_threads - nr_trim_pages (only if CONFIG_MMU=n) - numa_zonelist_order - oom_dump_tasks@@ -426,16 +425,6 @@ See Documentation/vm/hugetlbpage.txt ============================================================== -nr_pdflush_threads - -The current number of pdflush threads. This value is read-only. -The value changes according to the number of dirty pages in the system. - -When necessary, additional pdflush threads are created, one per second, up to -nr_pdflush_threads_max. - -============================================================== - nr_trim_pages This is available only on NOMMU kernels.fs/fs-writeback.c +0
-5@@ -52,11 +52,6 @@ struct wb_writeback_work {struct completion *done;/* set if the caller waits */ }; -/* -* We don't actually have pdflush, but this one is exported though /proc... -*/ -int nr_pdflush_threads; -/** * writeback_in_progress - determine whether there is writeback in progress * @bdi: the device's backing_dev_info structure. include/linux/writeback.h +0
-5@@ -193,9 +193,4 @@ void tag_pages_for_writeback(struct address_space *mapping,void account_page_redirty (struct page *page); -/* pdflush.c */ -extern int nr_pdflush_threads;/* Global so it can be exported to sysctl -read-only. */ - -#endif /* WRITEBACK_H */ kernel/sysctl.c +0
-7@@ -1095,13 +1095,6 @@ static struct ctl_table vm_table[] = { .extra1 = &zero, }, { - .procname = "nr_pdflush_threads", - .data = &nr_pdflush_threads, - .maxlen = sizeof nr_pdflush_threads, - .mode = 0444 /* read-only*/, - .proc_handler = proc_dointvec, - }, - { .procname = "swappiness", .data = &vm_swappiness, .maxlen = sizeof(vm_swappiness),Signature · 1 line
1.7.9.5
Quoted 11 lines · Fengguang Wu
Hi Wanpeng,
Quoted 3 lines · Wanpeng Li
From: Wanpeng Li <[email protected]>
remove no longer use of pdflush interface
nr_pdflush_threads.The patch looks good in itself: the
nr_pdflush_threadstakes no effect for many of the recent kernels. But what's the normal process of interface removal? Shall we carry some warning printk for some time first or whatever?
Yes. you have to add printk warning for noticing it deprecated. And add descriptoin in Documentation/ABI/obsolete/ and Documentation/feature-removal-schedule.txt
I don't know how long we maintain it. Is there any rule for it? Maybe 1-year is suitable, IMHO.
Thanks.
Signature · 6 lines
Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Fengguang Wu
Hi Wanpeng,
Quoted 3 lines · Wanpeng Li
From: Wanpeng Li <[email protected]>
remove no longer use of pdflush interface
nr_pdflush_threads.The patch looks good in itself: the
nr_pdflush_threadstakes no effect for many of the recent kernels. But what's the normal process of interface removal? Shall we carry some warning printk for some time first or whatever?
Hi, Fengguang,
I also want to add an interface of nr_bdi_writeback_threads to statistic how many flusher-x:y currently running, do you think it is a good idea?
Regards,
Wanpeng Li
Quoted 89 lines
Quoted 89 lines
Signed-off-by Wanpeng Li <[email protected]>--- Documentation/sysctl/vm.txt | 11 ----------- fs/fs-writeback.c | 5 ----- include/linux/writeback.h | 5 ----- kernel/sysctl.c | 7 ------- 4 files changed, 28 deletions(-)Documentation/sysctl/vm.txt +0
-11@@ -42,7 +42,6 @@ Currently, these files are in /proc/sys/vm: - mmap_min_addr - nr_hugepages - nr_overcommit_hugepages -- nr_pdflush_threads - nr_trim_pages (only if CONFIG_MMU=n) - numa_zonelist_order - oom_dump_tasks@@ -426,16 +425,6 @@ See Documentation/vm/hugetlbpage.txt ============================================================== -nr_pdflush_threads - -The current number of pdflush threads. This value is read-only. -The value changes according to the number of dirty pages in the system. - -When necessary, additional pdflush threads are created, one per second, up to -nr_pdflush_threads_max. - -============================================================== - nr_trim_pages This is available only on NOMMU kernels.fs/fs-writeback.c +0
-5@@ -52,11 +52,6 @@ struct wb_writeback_work {struct completion *done;/* set if the caller waits */ }; -/* -* We don't actually have pdflush, but this one is exported though /proc... -*/ -int nr_pdflush_threads; -/** * writeback_in_progress - determine whether there is writeback in progress * @bdi: the device's backing_dev_info structure. include/linux/writeback.h +0
-5@@ -193,9 +193,4 @@ void tag_pages_for_writeback(struct address_space *mapping,void account_page_redirty (struct page *page); -/* pdflush.c */ -extern int nr_pdflush_threads;/* Global so it can be exported to sysctl -read-only. */ - -#endif /* WRITEBACK_H */ kernel/sysctl.c +0
-7@@ -1095,13 +1095,6 @@ static struct ctl_table vm_table[] = { .extra1 = &zero, }, { - .procname = "nr_pdflush_threads", - .data = &nr_pdflush_threads, - .maxlen = sizeof nr_pdflush_threads, - .mode = 0444 /* read-only*/, - .proc_handler = proc_dointvec, - }, - { .procname = "swappiness", .data = &vm_swappiness, .maxlen = sizeof(vm_swappiness),Signature · 1 line
1.7.9.5
Quoted 13 lines · Wanpeng Li
Quoted 11 lines · Fengguang Wu
Hi Wanpeng,
Quoted 3 lines · Wanpeng Li
From: Wanpeng Li <[email protected]>
remove no longer use of pdflush interface
nr_pdflush_threads.The patch looks good in itself: the
nr_pdflush_threadstakes no effect for many of the recent kernels. But what's the normal process of interface removal? Shall we carry some warning printk for some time first or whatever?
Quoted 4 lines
Hi, Fengguang,
I also want to add an interface of
nr_bdi_writeback_threadsto statistic how many flusher-x:y currently running, do you think it is a good idea?
Hmm, we try to avoid adding interfaces without a good reason. What would be the use case? Are there real user demands for this at all?
Thanks,
Fengguang
Quoted 87 lines
Quoted 87 lines
Quoted 87 lines
Signed-off-by Wanpeng Li <[email protected]>--- Documentation/sysctl/vm.txt | 11 ----------- fs/fs-writeback.c | 5 ----- include/linux/writeback.h | 5 ----- kernel/sysctl.c | 7 ------- 4 files changed, 28 deletions(-)Documentation/sysctl/vm.txt +0
-11@@ -42,7 +42,6 @@ Currently, these files are in /proc/sys/vm: - mmap_min_addr - nr_hugepages - nr_overcommit_hugepages -- nr_pdflush_threads - nr_trim_pages (only if CONFIG_MMU=n) - numa_zonelist_order - oom_dump_tasks@@ -426,16 +425,6 @@ See Documentation/vm/hugetlbpage.txt ============================================================== -nr_pdflush_threads - -The current number of pdflush threads. This value is read-only. -The value changes according to the number of dirty pages in the system. - -When necessary, additional pdflush threads are created, one per second, up to -nr_pdflush_threads_max. - -============================================================== - nr_trim_pages This is available only on NOMMU kernels.fs/fs-writeback.c +0
-5@@ -52,11 +52,6 @@ struct wb_writeback_work {struct completion *done;/* set if the caller waits */ }; -/* -* We don't actually have pdflush, but this one is exported though /proc... -*/ -int nr_pdflush_threads; -/** * writeback_in_progress - determine whether there is writeback in progress * @bdi: the device's backing_dev_info structure. include/linux/writeback.h +0
-5@@ -193,9 +193,4 @@ void tag_pages_for_writeback(struct address_space *mapping,void account_page_redirty (struct page *page); -/* pdflush.c */ -extern int nr_pdflush_threads;/* Global so it can be exported to sysctl -read-only. */ - -#endif /* WRITEBACK_H */ kernel/sysctl.c +0
-7@@ -1095,13 +1095,6 @@ static struct ctl_table vm_table[] = { .extra1 = &zero, }, { - .procname = "nr_pdflush_threads", - .data = &nr_pdflush_threads, - .maxlen = sizeof nr_pdflush_threads, - .mode = 0444 /* read-only*/, - .proc_handler = proc_dointvec, - }, - { .procname = "swappiness", .data = &vm_swappiness, .maxlen = sizeof(vm_swappiness),Signature · 1 line
1.7.9.5