Skip to contentSkip to conversation

python-numpy : Add missing dependencies.

PATCH In review Dan McDougall 4 participants 8 messages Jun 6, 2012 – Jun 7, 2012

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 python-numpy : Add missing dependencies.

Numpy was missing a number of dependencies in the .bb file without which it will not work.

---
 .../recipes-devtools/python/python-numpy_1.4.1.bb  |    5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +5 -0
index 36ab622..bae624e 100644
@@ -24,3 +24,8 @@ do_compile_prepend() {
 
 SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
 SRC_URI[sha256sum] = "2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"
+
+RDEPENDS_${PN} = "python-unittest \
+                  python-diffutils \
+                  python-pprint \
+                 "
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 2/2 python-numpy : Correct difflib dependency.

The previous patch had python-diffutils when it should have been python-difflib.

---
 .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
index bae624e..702f224 100644
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
 SRC_URI[sha256sum] = "2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"
 
 RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                   python-pprint \
                  "
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

Quoted 13 lines · Dan McDougall

The previous patch had python-diffutils when it should have been python-difflib.

---
  .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +0 -0
index bae624e..702f224 100644

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 31

Quoted 7 lines
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
  SRC_URI[sha256sum] = "2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"
 
  RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                    python-pprint \
                   "

Since these patches have not yet been accepted/merged, shouldn't you squash them into one?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#3 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

Quoted 16 lines · Gary Thomas
Quoted 15 lines · Dan McDougall

The previous patch had python-diffutils when it should have been python-difflib.

---
  .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +0 -0
index bae624e..702f224 100644
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
  SRC_URI[sha256sum] = "2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"
 
Quoted 8 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 31

Quoted 5 lines
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
  RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                    python-pprint \
                   "

Since these patches have not yet been accepted/merged, shouldn't you squash them into one?

Once again:

http://git.openembedded.org/meta-openembedded/commit/?id=036eb620206041bf1cf4be5a8c2a4947afb34382

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

In reply to Gary Thomas
Quoted 16 lines · Gary Thomas
Quoted 15 lines · Dan McDougall

The previous patch had python-diffutils when it should have been python-difflib.

---
  .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +0 -0
index bae624e..702f224 100644
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
  SRC_URI[sha256sum] = "2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"
 
Quoted 8 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 31

Quoted 5 lines
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
  RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                    python-pprint \
                   "

Since these patches have not yet been accepted/merged, shouldn't you squash them into one?

And interestingly someone found completely different set of deps a while ago..

http://patchwork.openembedded.org/patch/3011/

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

Quoted 35 lines · Martin Jansa
Quoted 10 lines · Gary Thomas

Review

Quoted 9 lines · Dan McDougall

The previous patch had python-diffutils when it should have been python-difflib.

---
  .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

python-numpy_1.4.1.bb

Quoted 5 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 26

Quoted 5 lines

index bae624e..702f224 100644

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +0 -0
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
  SRC_URI[sha256sum] =

"2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"

Quoted 9 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 31

Quoted 6 lines
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
  RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                    python-pprint \
                   "

Since these patches have not yet been accepted/merged, shouldn't you squash them into one?

And interestingly someone found completely different set of deps a while ago..

http://patchwork.openembedded.org/patch/3011/

Cheers,

Quoted 9 lines

--
Martin 'JaMa' Jansa jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Well, Koen already committed my previous patch so I submitted the difflib fix for that. I included it as a 2/2 for context (not sure if that's the right thing to do).

As for that other patch's dependencies, they're not correct: I have numpy installed on my Beaglebone right now and it works great without python-mmap, python-compiler, python-pydoc, or python-pkgutil.
python-unittest is definitely required though but that's in my patch
already.

Signature · 3 lines
Dan McDougall - Chief Executive Officer and Developer
Liftoff Software ✈ Your flight to the cloud is now boarding.
904-446-8323
#6 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

Quoted 50 lines · Daniel McDougall
Quoted 35 lines · Martin Jansa
Quoted 10 lines · Gary Thomas

Review

Quoted 9 lines · Dan McDougall

The previous patch had python-diffutils when it should have been python-difflib.

---
  .../recipes-devtools/python/python-numpy_1.4.1.bb  |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

python-numpy_1.4.1.bb

Quoted 5 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 26

Quoted 5 lines

index bae624e..702f224 100644

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +0 -0
@@ -26,6 +26,6 @@ SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b"
  SRC_URI[sha256sum] =

"2e7bb84573e5123e07f3c919fd433bc09b78d606252b6b719e385c2a981d8e06"

Quoted 9 lines

meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb SRC_URI[md5sum] = "5c7b5349dc3161763f7f366ceb96516b" · line 31

Quoted 6 lines
meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +1 -1
  RDEPENDS_${PN} = "python-unittest \
-                  python-diffutils \
+                  python-difflib \
                    python-pprint \
                   "

Since these patches have not yet been accepted/merged, shouldn't you squash them into one?

And interestingly someone found completely different set of deps a while ago..

http://patchwork.openembedded.org/patch/3011/

Cheers,

Quoted 9 lines

--
Martin 'JaMa' Jansa jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Well, Koen already committed my previous patch so I submitted the difflib fix for that. I included it as a 2/2 for context (not sure if that's the right thing to do).

Quoted 6 lines

As for that other patch's dependencies, they're not correct: I have numpy installed on my Beaglebone right now and it works great without python-mmap, python-compiler, python-pydoc, or python-pkgutil.
python-unittest is definitely required though but that's in my patch
already.

I wonder if you take a different path through numpy, will it import some additional python modules?

Philip

#7 lore raw

Re: [meta-oe][PATCH v2 2/2] python-numpy : Correct difflib dependency.

Quoted 5 lines · Philip Balister

I wonder if you take a different path through numpy, will it import some additional python modules?

I don't think so. I ran through a bunch of tests with my python-numpy package and all went well. I didn't encounter any errors. Given, I didn't test *everything* :)

Signature · 3 lines
Dan McDougall - Chief Executive Officer and Developer
Liftoff Software ✈ Your flight to the cloud is now boarding.
904-446-8323