Skip to contentSkip to conversation

regulator: rc5t583: Simplify rc5t583_set_voltage_time_sel implementation

PATCH Applied Axel Lin 3 participants 3 messages Jun 7, 2012 – Jun 8, 2012 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: rc5t583: Simplify rc5t583_set_voltage_time_sel implementation

For linear mappings, we can use below equation to get the voltage difference between new_selector and old_selector:

abs(new_selector - old_selector) * rdev->desc->uV_step

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/rc5t583-regulator.c |   14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)
drivers/regulator/rc5t583-regulator.c +3 -11
index 1d34e64..332eae8 100644
@@ -70,18 +70,10 @@ static int rc5t583_set_voltage_time_sel(struct regulator_dev *rdev,
 		unsigned int old_selector, unsigned int new_selector)
 {
 	struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
-	int old_uV, new_uV;
-	old_uV = regulator_list_voltage_linear(rdev, old_selector);
 
-	if (old_uV < 0)
-		return old_uV;
-
-	new_uV = regulator_list_voltage_linear(rdev, new_selector);
-	if (new_uV < 0)
-		return new_uV;
-
-	return DIV_ROUND_UP(abs(old_uV - new_uV),
-				reg->reg_info->change_uv_per_us);
+	return DIV_ROUND_UP(abs(new_selector - old_selector) *
+			    rdev->desc->uV_step,
+			    reg->reg_info->change_uv_per_us);
 }
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Axel Lin

For linear mappings, we can use below equation to get the voltage difference between new_selector and old_selector:

abs(new_selector - old_selector) * rdev->desc->uV_step

Acked-by Laxman Dewangan <[email protected]>

Looks good to me.

Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

For linear mappings, we can use below equation to get the voltage difference between new_selector and old_selector:

Applied, thanks.