Skip to contentSkip to conversation

x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

PATCH In review Shuah Khan 2 participants 3 messages Jun 13, 2012 – Jun 14, 2012 x86

lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

PATCH 1/1 x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted simple_strtoul().

Signed-off-by Shuah Khan <[email protected]>
---
 arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/mtrr/cleanup.c +1 -1
index ac140c7..601aa4e 100644
@@ -465,7 +465,7 @@ static unsigned long nr_mtrr_spare_reg __initdata =
 static int __init parse_mtrr_spare_reg(char *arg)
 {
 	if (arg)
-		nr_mtrr_spare_reg = simple_strtoul(arg, NULL, 0);
+		kstrtoul(arg, 0, &nr_mtrr_spare_reg);
 	return 0;
 }
 early_param("mtrr_spare_reg_nr", parse_mtrr_spare_reg);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 7 lines · Shuah Khan

Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted simple_strtoul().

Signed-off-by Shuah Khan <[email protected]>
---
 arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There's about 22 simple_strto*() uses remaining in arch/x86/ - please send a single patch that addresses them in one go, instead of these peacemail patches...

Thanks,

Ingo

author
#2 lore raw
Quoted 5 lines · Ingo Molnar
Quoted 3 lines · Shuah Khan

Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted simple_strtoul().

Quoted 9 lines
Quoted 4 lines
Signed-off-by Shuah Khan <[email protected]>
---
 arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There's about 22 simple_strto*() uses remaining in arch/x86/ - please send a single patch that addresses them in one go, instead of these peacemail patches...

Since I use my personal spare time doing this type of work it is easier for me to work on one patch at a time, however I understand it will be easier for you to pull in a single large patch as opposed to multiple. I will pool my changes and send them in a single patch.

-- Shuah