Skip to contentSkip to conversation

Fix comments in mm/memblock.c

PATCH In review Li Zhong 2 participants 3 messages Jun 14, 2012

Subsystems (2)
Memory management memblock and memory management initialization
lore
Share & tools
lore

Li Zhong

author
#0 lore raw

PATCH 1/1 Fix comments in mm/memblock.c

Make the parameter names in comments consistent with the actual ones used in the function.

Signed-off-by Li Zhong <[email protected]>
---
 mm/memblock.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/memblock.c +0 -0
index 952123e..76cb09f 100644
@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t

base, phys_addr_t size)
* __next_free_mem_range - next function for for_each_free_mem_range()
* @idx: pointer to u64 loop variable
* @nid: nid: node selector, %MAX_NUMNODES for all nodes
- * @p_start: ptr to phys_addr_t for start address of the range, can be %NULL
- * @p_end: ptr to phys_addr_t for end address of the range, can be % NULL
- * @p_nid: ptr to int for nid of the range, can be %NULL
+ * @out_start: ptr to phys_addr_t for start address of the range, can be %NULL
+ * @out_end: ptr to phys_addr_t for end address of the range, can be % NULL
+ * @out_nid: ptr to int for nid of the range, can be %NULL *
* Find the first free area from *@idx which matches @nid, fill the out
* parameters, and update *@idx for the next iteration. The lower
32bit of

Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 7 lines · Li Zhong

Make the parameter names in comments consistent with the actual ones used in the function.

Signed-off-by Li Zhong <[email protected]>

---
mm/memblock.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

Hi Li Zhong,

I have already send a path to fix this issues.
title is "mm:fix kernel-doc warnings"

Regards,
Wanpeng Li

Quoted 32 lines
mm/memblock.c +0 -1
index 952123e..76cb09f 100644
@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t
 base, phys_addr_t size)
 * __next_free_mem_range - next function for for_each_free_mem_range()
 * @idx: pointer to u64 loop variable
 * @nid: nid: node selector, %MAX_NUMNODES for all nodes
- * @p_start: ptr to phys_addr_t for start address of the range, can be

%NULL
- * @p_end: ptr to phys_addr_t for end address of the range, can be % NULL
- * @p_nid: ptr to int for nid of the range, can be %NULL
+ * @out_start: ptr to phys_addr_t for start address of the range, can be %NULL
+ * @out_end: ptr to phys_addr_t for end address of the range, can be % NULL
+ * @out_nid: ptr to int for nid of the range, can be %NULL *
* Find the first free area from *@idx which matches @nid, fill the out
* parameters, and update *@idx for the next iteration. The lower
32bit of

Signature · 7 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
author
#2 lore raw
Quoted 9 lines · Wanpeng Li
Quoted 7 lines · Li Zhong

Make the parameter names in comments consistent with the actual ones used in the function.

Signed-off-by Li Zhong <[email protected]>

---
mm/memblock.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 4 lines

Hi Li Zhong,

I have already send a path to fix this issues.
title is "mm:fix kernel-doc warnings"

Ah, ok.

Sorry for the noise ...

Quoted 37 lines

Regards,
Wanpeng Li

Quoted 32 lines
mm/memblock.c +0 -1
index 952123e..76cb09f 100644
@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t
 base, phys_addr_t size)
 * __next_free_mem_range - next function for for_each_free_mem_range()
 * @idx: pointer to u64 loop variable
 * @nid: nid: node selector, %MAX_NUMNODES for all nodes
- * @p_start: ptr to phys_addr_t for start address of the range, can be

%NULL
- * @p_end: ptr to phys_addr_t for end address of the range, can be % NULL
- * @p_nid: ptr to int for nid of the range, can be %NULL
+ * @out_start: ptr to phys_addr_t for start address of the range, can be %NULL
+ * @out_end: ptr to phys_addr_t for end address of the range, can be % NULL
+ * @out_nid: ptr to int for nid of the range, can be %NULL *
* Find the first free area from *@idx which matches @nid, fill the out
* parameters, and update *@idx for the next iteration. The lower
32bit of

Signature · 7 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/