drm/i915: prevent possible pin leak on error path
Subsystems (2)
PATCH 1/1 drm/i915: prevent possible pin leak on error path
We should not hit this under any sane conditions, but still, this does not looks right.
CC Chris Wilson <[email protected]>
CC Daniel Vetter <[email protected]>
Reported-by Herton Ronaldo Krzesinski <[email protected]>
Signed-off-by Eugeni Dodonov <[email protected]>
--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -6178,7 +6178,7 @@ static int intel_gen7_queue_flip(struct drm_device *dev,default :WARN_ONCE (1 ,"unknown plane in flip command\n" ); ret = -ENODEV ; - goto err; + goto err_unpin; } ret =intel_ring_begin (ring,4 );
Signature · 1 line
1.7.10.4
Quoted 2 lines · Eugeni Dodonov
We should not hit this under any sane conditions, but still, this does not looks right.
For pedagology.
Quoted 6 lines
CC Chris Wilson <[email protected]>CC Daniel Vetter <[email protected]>Reported-by Herton Ronaldo Krzesinski <[email protected]>Signed-off-by Eugeni Dodonov <[email protected]>
Whoever hits this has much bigger issues at hand...
Reviewed-by Chris Wlison <[email protected]>
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Daniel Vetter
AppliedQuoted 6 lines · Chris Wilson
Quoted 2 lines · Eugeni Dodonov
We should not hit this under any sane conditions, but still, this does not looks right.
For pedagology.
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
CC Chris Wilson <[email protected]>CC Daniel Vetter <[email protected]>Reported-by Herton Ronaldo Krzesinski <[email protected]>Signed-off-by Eugeni Dodonov <[email protected]>Whoever hits this has much bigger issues at hand...
Reviewed-by Chris Wlison <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48