Skip to contentSkip to conversation

drm/i915: prevent possible pin leak on error path

PATCH Applied Eugeni Dodonov 3 participants 3 messages Jun 18, 2012 – Jul 26, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: prevent possible pin leak on error path

We should not hit this under any sane conditions, but still, this does not looks right.

---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 7b3990e..5b50b5f 100644
@@ -6178,7 +6178,7 @@ static int intel_gen7_queue_flip(struct drm_device *dev,
 	default:
 		WARN_ONCE(1, "unknown plane in flip command\n");
 		ret = -ENODEV;
-		goto err;
+		goto err_unpin;
 	}
 
 	ret = intel_ring_begin(ring, 4);
Signature · 1 line
1.7.10.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Eugeni Dodonov

We should not hit this under any sane conditions, but still, this does not looks right.

For pedagology.

Quoted 6 lines

Whoever hits this has much bigger issues at hand...

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 6 lines · Chris Wilson
Quoted 2 lines · Eugeni Dodonov

We should not hit this under any sane conditions, but still, this does not looks right.

For pedagology.

Quoted 1 line
Quoted 8 lines
Quoted 5 lines

Whoever hits this has much bigger issues at hand...

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48