Skip to contentSkip to conversation

asoc: bfin: use dev_err to print error log instead of dev_dbg

PATCH Applied Scott Jiang 4 participants 8 messages Jun 21, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 asoc: bfin: use dev_err to print error log instead of dev_dbg

---
 sound/soc/blackfin/bf6xx-sport.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/blackfin/bf6xx-sport.c +2 -2
index f19a72b..318c5ba 100644
@@ -256,9 +256,9 @@ static irqreturn_t sport_err_irq(int irq, void *dev_id)
 	struct device *dev = &sport->pdev->dev;
 
 	if (sport->tx_regs->spctl & SPORT_CTL_DERRPRI)
-		dev_dbg(dev, "sport error: TUVF\n");
+		dev_err(dev, "sport error: TUVF\n");
 	if (sport->rx_regs->spctl & SPORT_CTL_DERRPRI)
-		dev_dbg(dev, "sport error: ROVF\n");
+		dev_err(dev, "sport error: ROVF\n");
 
 	return IRQ_HANDLED;
 }
Signature · 1 line
1.7.0.4
#2 lore raw

2012/6/21 Mark Brown <[email protected]>:

Quoted 5 lines · Scott Jiang
Quoted 1 line

Applied, but as I said last time you should use subject lines that match up with the rest of the subsystem.

Sorry, I'm not sure what you mean. Do you mean 80 columns or style? Could you please give me more details?

Thanks,
Scott

#3 lore raw
Quoted 9 lines · Scott Jiang

2012/6/21 Mark Brown <[email protected]>:

Quoted 5 lines · Scott Jiang
Quoted 1 line

Applied, but as I said last time you should use subject lines that match up with the rest of the subsystem.

Sorry, I'm not sure what you mean. Do you mean 80 columns or style? Could you please give me more details?

You're calling the subsystem "asoc" not "ASoC".

#4 lore raw

Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

Quoted 5 lines · Mark Brown
Quoted 3 lines · Scott Jiang

2012/6/21 Mark Brown<[email protected]>:

Quoted 2 lines · Scott Jiang
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Applied, but as I said last time you should use subject lines that match up with the rest of the subsystem.

Sorry, I'm not sure what you mean. Do you mean 80 columns or style? Could you please give me more details?

You're calling the subsystem "asoc" not "ASoC".

While we're at it, how about switching to the a/b/c style used by several other subsystems?

I personally think "alsa/hda/realtek" looks much prettier than the shoutier "ALSA: HDA: Realtek:" thing we have today.

Signature · 2 lines
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
#5 lore raw

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

Quoted 2 lines · David Henningsson

While we're at it, how about switching to the a/b/c style used by several other subsystems?

Looking at the git logs that's *really* unusual.

Quoted 2 lines

I personally think "alsa/hda/realtek" looks much prettier than the shoutier "ALSA: HDA: Realtek:" thing we have today.

I have to say I really don't like this, especially the lowercasing of everything. It doesn't read like normal text, it reads like a filename.

#6 lore raw

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

At Thu, 21 Jun 2012 16:22:44 +0100,

Quoted 7 lines · Mark Brown
Quoted 2 lines · David Henningsson

While we're at it, how about switching to the a/b/c style used by several other subsystems?

Looking at the git logs that's *really* unusual.

I'd say it's between usual and unusual :)
Driver-local commits tend to have a prefix with the path (or omitting "drivers/"). So in our case it'd be "sound/soc/codec: xxx" or "sound/pci/hda: xxx".

Quoted 5 lines
Quoted 2 lines

I personally think "alsa/hda/realtek" looks much prettier than the shoutier "ALSA: HDA: Realtek:" thing we have today.

I have to say I really don't like this, especially the lowercasing of everything. It doesn't read like normal text, it reads like a filename.

Yeah, I share the same feeling. The words like ALSA or ASoC don't fit with lower letters well.

Takashi

#7 lore raw

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

Quoted 8 lines · Takashi Iwai
Quoted 1 line · Mark Brown

Looking at the git logs that's *really* unusual.

I'd say it's between usual and unusual :)
Driver-local commits tend to have a prefix with the path (or omitting "drivers/"). So in our case it'd be "sound/soc/codec: xxx" or "sound/pci/hda: xxx".

Yeah, I was mainly thinking of the subsystem: bit which is pretty much the norm (with a few exceptions).