Skip to contentSkip to conversation

bitbake.conf/abi_version.conf: Update to use BasicHash signature generator

PATCH In review Richard Purdie 4 participants 8 messages Jun 22, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf/abi_version.conf: Update to use BasicHash signature generator

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Angstrom, SHR and Poky did this a while ago. This brings the OE-Core defaults into line with what is the best common practise at this point. Its been discussed on the mailing lists and by the TSC at length, this just completes the transition.

---
 meta/conf/abi_version.conf |    2 +-
 meta/conf/bitbake.conf     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta/conf/abi_version.conf +1 -1
index f2919e5..83b668a 100644
@@ -4,4 +4,4 @@
 # that breaks the format and have been previously discussed on the mailing list 
 # with general agreement from the core team.
 #
-OELAYOUT_ABI = "7"
+OELAYOUT_ABI = "8"
meta/conf/bitbake.conf +1 -1
index b6fbc7a..fbc0ca2 100644
@@ -748,7 +748,7 @@ TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
 
 # Setup our default hash policy
-BB_SIGNATURE_HANDLER ?= "OEBasic"
+BB_SIGNATURE_HANDLER ?= "OEBasicHash"
 BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH DL_DIR SSTATE_DIR THISDIR FILESEXTRAPATHS FILE_DIRNAME HOME LOGNAME SHELL TERM USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST PRSERV_PORT PRSERV_DUMPDIR PRSERV_DUMPFILE PRSERV_LOCKDOWN PARALLEL_MAKE CCACHE_DIR EXTERNAL_TOOLCHAIN CCACHE"
 BB_HASHCONFIG_WHITELIST ?= "${BB_HASHBASE_WHITELIST} DATE TIME SESSION_MANAGER DBUS_SESSION_BUS_ADDRESS SSH_AGENT_PID XDG_SESSION_COOKIE SSH_AUTH_SOCK XAUTHORITY PSEUDO_BUILD"
 BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc defaultval _append _prepend deps depends lockfiles type vardepsexclude \
#1 lore raw
Quoted 9 lines · Richard Purdie

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Angstrom, SHR and Poky did this a while ago. This brings the OE-Core defaults into line with what is the best common practise at this point. Its been discussed on the mailing lists and by the TSC at length, this just completes the transition.

thanks looks good

Quoted 35 lines

---
 meta/conf/abi_version.conf |    2 +-
 meta/conf/bitbake.conf     |    2 +-

 2 files changed, 2 insertions(+), 2 deletions(-)
meta/conf/abi_version.conf +1 -1
index f2919e5..83b668a 100644
@@ -4,4 +4,4 @@
  # that breaks the format and have been previously discussed on the mailing list
  # with general agreement from the core team.
  #
-OELAYOUT_ABI = "7"
+OELAYOUT_ABI = "8"
meta/conf/bitbake.conf +0 -0
index b6fbc7a..fbc0ca2 100644
@@ -748,7 +748,7 @@ TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"

 BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"

 # Setup our default hash policy

meta/conf/bitbake.conf +1 -1
-BB_SIGNATURE_HANDLER ?= "OEBasic"
+BB_SIGNATURE_HANDLER ?= "OEBasicHash"

 BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH DL_DIR SSTATE_DIR THISDIR FILESEXTRAPATHS FILE_DIRNAME HOME LOGNAME SHELL TERM USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST PRSERV_PORT PRSERV_DUMPDIR PRSERV_DUMPFILE PRSERV_LOCKDOWN PARALLEL_MAKE CCACHE_DIR EXTERNAL_TOOLCHAIN CCACHE" BB_HASHCONFIG_WHITELIST ?= "${BB_HASHBASE_WHITELIST} DATE TIME SESSION_MANAGER DBUS_SESSION_BUS_ADDRESS SSH_AGENT_PID XDG_SESSION_COOKIE SSH_AUTH_SOCK XAUTHORITY PSEUDO_BUILD"
 BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc defaultval _append _prepend deps depends lockfiles type vardepsexclude \

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#2 lore raw
In reply to Richard Purdie

Richard Purdie <[email protected]>

Quoted 2 lines · writes:

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Has this really been tested? I played a little bit with it and it was very painful when whole distribution will be rebuilt due to a minor change in an early package.

There are some subtle bugs in the hash generation too (e.g. bitbake's get_file_depends() result is used to calculate a hash over a set() which is filled nondeterministically when BB_NUMBER_THREADS>1) which cause random rebuilds too.

Enrico

#3 lore raw
Quoted 1 line · Enrico Scholz

Has this really been tested?

Angstrom. SHR, yocto has it on by default for months now. No one reported issues thus far.

#4 lore raw
In reply to Enrico Scholz
Quoted 8 lines · Enrico Scholz

Richard Purdie <[email protected]>

Quoted 2 lines · writes:

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Has this really been tested?

Its the default in Poky and Angstrom. It was the default for the Yocto Project 1.2 release too. So yes, it has seen testing.

Quoted 8 lines

I played a little bit with it and it was
very painful when whole distribution will be rebuilt due to a minor change in an early package.

There are some subtle bugs in the hash generation too (e.g. bitbake's get_file_depends() result is used to calculate a hash over a set() which is filled nondeterministically when BB_NUMBER_THREADS>1) which cause random rebuilds too.

Bug reports on issues like this would be good, we can't fix a problem if we don't know about it.

Cheers,

Richard

#5 lore raw

Richard Purdie <[email protected]>

Quoted 7 lines · writes:
Quoted 4 lines

There are some subtle bugs in the hash generation too (e.g. bitbake's get_file_depends() result is used to calculate a hash over a set() which is filled nondeterministically when BB_NUMBER_THREADS>1) which cause random rebuilds too.

Bug reports on issues like this would be good, we can't fix a problem if we don't know about it.

http://lists.linuxtogo.org/pipermail/bitbake-devel/2012-May/002951.html

Enrico

#6 lore raw
In reply to Richard Purdie
Quoted 4 lines · Richard Purdie

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Angstrom, SHR and Poky did this a while ago. This brings the OE-Core defaults

SHR didn't (except my testing), but I'm fine with this change.. I'll override it in back to OEBasic in meta-shr layer (at least until we get faster official feed builder..).

Cheers,

Quoted 40 lines

into line with what is the best common practise at this point. Its been discussed on the mailing lists and by the TSC at length, this just completes the transition.

---
 meta/conf/abi_version.conf |    2 +-
 meta/conf/bitbake.conf     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta/conf/abi_version.conf +1 -1
index f2919e5..83b668a 100644
@@ -4,4 +4,4 @@
 # that breaks the format and have been previously discussed on the mailing list 
 # with general agreement from the core team.
 #
-OELAYOUT_ABI = "7"
+OELAYOUT_ABI = "8"
meta/conf/bitbake.conf +1 -1
index b6fbc7a..fbc0ca2 100644
@@ -748,7 +748,7 @@ TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
 
 # Setup our default hash policy
-BB_SIGNATURE_HANDLER ?= "OEBasic"
+BB_SIGNATURE_HANDLER ?= "OEBasicHash"
 BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH DL_DIR SSTATE_DIR THISDIR FILESEXTRAPATHS FILE_DIRNAME HOME LOGNAME SHELL TERM USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST PRSERV_PORT PRSERV_DUMPDIR PRSERV_DUMPFILE PRSERV_LOCKDOWN PARALLEL_MAKE CCACHE_DIR EXTERNAL_TOOLCHAIN CCACHE"
 BB_HASHCONFIG_WHITELIST ?= "${BB_HASHBASE_WHITELIST} DATE TIME SESSION_MANAGER DBUS_SESSION_BUS_ADDRESS SSH_AGENT_PID XDG_SESSION_COOKIE SSH_AUTH_SOCK XAUTHORITY PSEUDO_BUILD"
 BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc defaultval _append _prepend deps depends lockfiles type vardepsexclude \

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#7 lore raw
Quoted 9 lines · Martin Jansa
Quoted 4 lines · Richard Purdie

This switches to use the hash based signature generatior and update layout_abi to match stamp file layout changes.

Angstrom, SHR and Poky did this a while ago. This brings the OE-Core defaults

SHR didn't (except my testing), but I'm fine with this change.. I'll override it in back to OEBasic in meta-shr layer (at least until we get faster official feed builder..).

Sorry, I thought you had switched, my mistake. I'll fix that commit message before merging.

Cheers,

Richard