ASoC: dapm: Try to add all routes even if one fails
PATCH 1/1 ASoC: dapm: Try to add all routes even if one fails
We may as well print as many errors as we can in one go rather than requiring developers to iterate through all their typos.
Signed-off-by Mark Brown <[email protected]>
--- sound/soc/soc-dapm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/soc-dapm.c +4 -4
@@ -2276,15 +2276,15 @@ err:int snd_soc_dapm_add_routes (struct snd_soc_dapm_context *dapm,const struct snd_soc_dapm_route *route,int num) { -int i, ret =0 ; +int i, r, ret =0 ;mutex_lock_nested (&dapm->card->dapm_mutex,SND_SOC_DAPM_CLASS_INIT );for (i =0 ; i < num; i++) { - ret =snd_soc_dapm_add_route (dapm, route); -if (ret <0 ) { + r =snd_soc_dapm_add_route (dapm, route); +if (r <0 ) {dev_err (dapm->dev,"Failed to add route %s->%s\n" , route->source, route->sink); -break ; + ret = r; } route++; }
Signature · 1 line
1.7.10
Quoted 4 lines · Mark Brown
We may as well print as many errors as we can in one go rather than requiring developers to iterate through all their typos.
Signed-off-by Mark Brown <[email protected]>
Acked-by Liam Girdwood <[email protected]>