Skip to contentSkip to conversation

regulator: arizona-micsupp: Fix choosing selector in arizona_micsupp_map_voltage

PATCH Applied Axel Lin 2 participants 2 messages Jun 26, 2012

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: arizona-micsupp: Fix choosing selector in arizona_micsupp_map_voltage

If min_uV is in the range of: 3250001~3269999,
current code uses the equation:

        selector = DIV_ROUND_UP(min_uV - 1700000, 50000);

Then selector will be 32.
Then arizona_micsupp_list_voltage returns -EINVAL for this case which is wrong.

This patch fixes this issue:
If min_uV > 3200000, selector should be ARIZONA_MICSUPP_MAX_SELECTOR.

---
 drivers/regulator/arizona-micsupp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/arizona-micsupp.c +1 -1
index 97d85b0..fdd7473 100644
@@ -57,7 +57,7 @@ static int arizona_micsupp_map_voltage(struct regulator_dev *rdev,
 	if (min_uV < 1700000)
 		min_uV = 1700000;
 
-	if (min_uV >= 3300000)
+	if (min_uV > 3200000)
 		selector = ARIZONA_MICSUPP_MAX_SELECTOR;
 	else
 		selector = DIV_ROUND_UP(min_uV - 1700000, 50000);
Signature · 1 line
1.7.9.5
Applied
#1 lore raw
Quoted 2 lines · Axel Lin

If min_uV is in the range of: 3250001~3269999,
current code uses the equation:

Applied, thanks.