Skip to contentSkip to conversation

pwm: pwm-bfin: Return proper error if pwmchip_remove() fails

PATCH Applied Axel Lin 3 participants 5 messages Jul 1, 2012 – Jul 2, 2012

Subsystems (2)
Arm i.MX and Layerscape PWM
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 pwm: pwm-bfin: Return proper error if pwmchip_remove() fails

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pwm/pwm-bfin.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-bfin.c +1 -3
index a0c6bf9..d53c4e7 100644
@@ -146,9 +146,7 @@ static int __devexit bfin_pwm_remove(struct platform_device *pdev)
 {
 	struct bfin_pwm_chip *pwm = platform_get_drvdata(pdev);
 
-	pwmchip_remove(&pwm->chip);
-
-	return 0;
+	return pwmchip_remove(&pwm->chip);
 }
 
 static struct platform_driver bfin_pwm_driver = {
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/2 pwm: pwm-mxs: Return proper error if pwmchip_remove() fails

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pwm/pwm-mxs.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-mxs.c +1 -3
index 269d7c2..e585264 100644
@@ -178,9 +178,7 @@ static int __devexit mxs_pwm_remove(struct platform_device *pdev)
 {
 	struct mxs_pwm_chip *mxs = platform_get_drvdata(pdev);
 
-	pwmchip_remove(&mxs->chip);
-
-	return 0;
+	return pwmchip_remove(&mxs->chip);
 }
 
 static struct of_device_id mxs_pwm_dt_ids[] = {
Signature · 1 line
1.7.9.5
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] pwm: pwm-mxs: Return proper error if pwmchip_remove() fails

Quoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Acked-by Shawn Guo <[email protected]>
Quoted 24 lines
---
 drivers/pwm/pwm-mxs.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-mxs.c +1 -3
index 269d7c2..e585264 100644
@@ -178,9 +178,7 @@ static int __devexit mxs_pwm_remove(struct platform_device *pdev)
 {
 	struct mxs_pwm_chip *mxs = platform_get_drvdata(pdev);
 
-	pwmchip_remove(&mxs->chip);
-
-	return 0;
+	return pwmchip_remove(&mxs->chip);
 }
 
 static struct of_device_id mxs_pwm_dt_ids[] = {
Signature · 1 line
1.7.9.5