Skip to contentSkip to conversation

arm: Fix kernel crash problem in binfmt_flat.c

PATCH New Max Neklyudov 1 participant 1 message Jul 5, 2012

Subsystems (2)
VFS exec and binfmt
lore
Share & tools
lore

Max Neklyudov

author
#0 lore raw

PATCH 1/1 arm: Fix kernel crash problem in binfmt_flat.c

If createion of the new process is aborted due to some erros (lack of memory in my case) kernel will crash because created process is not terminated properly.
I just sent SIG_KILL in all such points.

Tested on my LM3S1D21 based board

Signed-off-by Max Neklyudov <[email protected]>
---
 fs/binfmt_flat.c |    5 +++++
 1 file changed, 5 insertions(+)
fs/binfmt_flat.c +5 -0
index 178cb70..79c9838 100644
@@ -545,6 +545,7 @@ static int load_flat_file(struct linux_binprm * bprm,
 		textpos = vm_mmap(bprm->file, 0, text_len, PROT_READ|PROT_EXEC,
 				  MAP_PRIVATE|MAP_EXECUTABLE, 0);
 		if (!textpos || IS_ERR_VALUE(textpos)) {
+			send_sig(SIGKILL, current, 0);
 			if (!textpos)
 				textpos = (unsigned long) -ENOMEM;
 			printk("Unable to mmap process text, errno %d\n", (int)-textpos);

@@ -558,6 +559,7 @@ static int load_flat_file(struct linux_binprm * bprm,
 			PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE, 0);
 
 		if (realdatastart == 0 || IS_ERR_VALUE(realdatastart)) {
+			send_sig(SIGKILL, current, 0);
 			if (!realdatastart)
 				realdatastart = (unsigned long) -ENOMEM;
 			printk("Unable to allocate RAM for process data, errno %d\n",

@@ -585,6 +587,7 @@ static int load_flat_file(struct linux_binprm * bprm,
 					data_len + (relocs * sizeof(unsigned long)), &fpos);
 		}
 		if (IS_ERR_VALUE(result)) {
+			send_sig(SIGKILL, current, 0);
 			printk("Unable to read data+bss, errno %d\n", (int)-result);
 			vm_munmap(textpos, text_len);
 			vm_munmap(realdatastart, len);

@@ -603,6 +606,7 @@ static int load_flat_file(struct linux_binprm * bprm,
 			PROT_READ | PROT_EXEC | PROT_WRITE, MAP_PRIVATE, 0);
 
 		if (!textpos || IS_ERR_VALUE(textpos)) {
+			send_sig(SIGKILL, current, 0);
 			if (!textpos)
 				textpos = (unsigned long) -ENOMEM;
 			printk("Unable to allocate RAM for process text/data, errno %d\n",

@@ -653,6 +657,7 @@ static int load_flat_file(struct linux_binprm * bprm,
 			}
 		}
 		if (IS_ERR_VALUE(result)) {
+			send_sig(SIGKILL, current, 0);
 			printk("Unable to read code+data+bss, errno %d\n",(int)-result);
 			vm_munmap(textpos, text_len + data_len + extra +
 				MAX_SHARED_LIBS * sizeof(unsigned long));
Signature · 1 line
1.7.9.5