Skip to contentSkip to conversation

mfd: max77686: Remove unused iolock mutex

PATCH In review Axel Lin 2 participants 2 messages Jul 6, 2012

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: max77686: Remove unused iolock mutex

Now this driver is using regmap API, the iolock mutex is not used and can be removed.

---
 drivers/mfd/max77686.c               |    3 ---
 include/linux/mfd/max77686-private.h |    1 -
 2 files changed, 4 deletions(-)
drivers/mfd/max77686.c +0 -3
index 11e5601..9e7e1d3 100644
@@ -27,7 +27,6 @@
 #include <linux/i2c.h>
 #include <linux/pm_runtime.h>
 #include <linux/module.h>
-#include <linux/mutex.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/max77686.h>
 #include <linux/mfd/max77686-private.h>
@@ -79,8 +78,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
 	max77686->wakeup = pdata->wakeup;
 	max77686->irq_gpio = pdata->irq_gpio;
 
-	mutex_init(&max77686->iolock);
-
 	if (regmap_read(max77686->regmap,
 			 MAX77686_REG_DEVICE_ID, &data) < 0) {
 		dev_err(max77686->dev,
include/linux/mfd/max77686-private.h +0 -1
index 962f65e..d327d49 100644
@@ -219,7 +219,6 @@ struct max77686_dev {
 	struct device *dev;
 	struct i2c_client *i2c; /* 0xcc / PMIC, Battery Control, and FLASH */
 	struct i2c_client *rtc; /* slave addr 0x0c */
-	struct mutex iolock;
 
 	int type;
 
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 52 lines · Axel Lin

Now this driver is using regmap API, the iolock mutex is not used and can be removed.

---
 drivers/mfd/max77686.c               |    3 ---
 include/linux/mfd/max77686-private.h |    1 -
 2 files changed, 4 deletions(-)
drivers/mfd/max77686.c +0 -3
index 11e5601..9e7e1d3 100644
@@ -27,7 +27,6 @@
 #include <linux/i2c.h>
 #include <linux/pm_runtime.h>
 #include <linux/module.h>
-#include <linux/mutex.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/max77686.h>
 #include <linux/mfd/max77686-private.h>
@@ -79,8 +78,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
        max77686->wakeup = pdata->wakeup;
        max77686->irq_gpio = pdata->irq_gpio;
 
-       mutex_init(&max77686->iolock);
-
        if (regmap_read(max77686->regmap,
                         MAX77686_REG_DEVICE_ID, &data) < 0) {
                dev_err(max77686->dev,
include/linux/mfd/max77686-private.h +0 -2
index 962f65e..d327d49 100644
@@ -219,7 +219,6 @@ struct max77686_dev {
        struct device *dev;
        struct i2c_client *i2c; /* 0xcc / PMIC, Battery Control, and FLASH */
        struct i2c_client *rtc; /* slave addr 0x0c */
-       struct mutex iolock;
 
        int type;
 
--

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/