Skip to contentSkip to conversation

regulator: max8952: Remove wrong set_suspend_disable callback setting

PATCH Applied Axel Lin 2 participants 3 messages Jul 6, 2012 – Jul 9, 2012 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 regulator: max8952: Remove wrong set_suspend_disable callback setting

Using the same ops for both .disable and .set_suspend_disable callbacks is actively broken. This patch removes .set_suspend_disable callback setting.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/max8952.c |    1 -
 1 file changed, 1 deletion(-)
drivers/regulator/max8952.c +0 -1
index 910c9b2..ea58a44 100644
@@ -151,7 +151,6 @@ static struct regulator_ops max8952_ops = {
 	.disable		= max8952_disable,
 	.get_voltage_sel	= max8952_get_voltage_sel,
 	.set_voltage_sel	= max8952_set_voltage_sel,
-	.set_suspend_disable	= max8952_disable,
 };
 
 static const struct regulator_desc regulator = {
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/2 regulator: max8998: Remove wrong set_suspend_[en|dis]able callback settings

Using the same ops for both [en|dis]able and set_suspend_[en|dis]able callbacks is actively broken. This patch removes .set_suspend_disable and .set_suspend_enable callback setting.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/max8998.c |    6 ------
 1 file changed, 6 deletions(-)
drivers/regulator/max8998.c +0 -6
index a1fa266..5dfa920 100644
@@ -460,8 +460,6 @@ static struct regulator_ops max8998_ldo_ops = {
 	.disable		= max8998_ldo_disable,
 	.get_voltage_sel	= max8998_get_voltage_sel,
 	.set_voltage_sel	= max8998_set_voltage_ldo_sel,
-	.set_suspend_enable	= max8998_ldo_enable,
-	.set_suspend_disable	= max8998_ldo_disable,
 };
 
 static struct regulator_ops max8998_buck_ops = {

@@ -473,16 +471,12 @@ static struct regulator_ops max8998_buck_ops = {
 	.get_voltage_sel	= max8998_get_voltage_sel,
 	.set_voltage_sel	= max8998_set_voltage_buck_sel,
 	.set_voltage_time_sel	= max8998_set_voltage_buck_time_sel,
-	.set_suspend_enable	= max8998_ldo_enable,
-	.set_suspend_disable	= max8998_ldo_disable,
 };
 
 static struct regulator_ops max8998_others_ops = {
 	.is_enabled		= max8998_ldo_is_enabled,
 	.enable			= max8998_ldo_enable,
 	.disable		= max8998_ldo_disable,
-	.set_suspend_enable	= max8998_ldo_enable,
-	.set_suspend_disable	= max8998_ldo_disable,
 };
 
 static struct regulator_desc regulators[] = {
Signature · 1 line
1.7.9.5
Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

Using the same ops for both .disable and .set_suspend_disable callbacks is actively broken. This patch removes .set_suspend_disable callback setting.

Applied both, thanks.