Skip to contentSkip to conversation

mfd: Remove __devexit annotation for pm80x_deinit

PATCH Applied Axel Lin 2 participants 2 messages Jul 11, 2012 – Jul 16, 2012 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 mfd: Remove __devexit annotation for pm80x_deinit

This fixes below section mismatch warning:

LD drivers/mfd/built-in.o
WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit() The function __devinit pm800_probe() references
a function __devexit pm80x_deinit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pm80x_deinit() so it may be used outside an exit section.

Signed-off-by Axel Lin <[email protected]>

---
v2: Also remove the __devexit annotation in 88pm80x.h

 drivers/mfd/88pm80x.c       |    2 +-
 include/linux/mfd/88pm80x.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/88pm80x.c +1 -1
index 62da342..cd0bf52 100644
@@ -91,7 +91,7 @@ err_regmap_init:
 }
 EXPORT_SYMBOL_GPL(pm80x_init);
 
-int __devexit pm80x_deinit(struct i2c_client *client)
+int pm80x_deinit(struct i2c_client *client)
 {
 	struct pm80x_chip *chip = i2c_get_clientdata(client);
include/linux/mfd/88pm80x.h +1 -1
index 103f06d..a0ca0dc 100644
@@ -365,5 +365,5 @@ static inline int pm80x_dev_resume(struct device *dev)
 
 extern int pm80x_init(struct i2c_client *client,
 			     const struct i2c_device_id *id) __devinit;
-extern int pm80x_deinit(struct i2c_client *client) __devexit;
+extern int pm80x_deinit(struct i2c_client *client);
 #endif /* __LINUX_MFD_88PM80X_H */
Signature · 1 line
1.7.9.5
Applied
#1 lore raw

Hi Axel,

Quoted 11 lines · Axel Lin

This fixes below section mismatch warning:

LD drivers/mfd/built-in.o
WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit() The function __devinit pm800_probe() references
a function __devexit pm80x_deinit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pm80x_deinit() so it may be used outside an exit section.

Quoted 7 lines
Signed-off-by Axel Lin <[email protected]>

---
v2: Also remove the __devexit annotation in 88pm80x.h

 drivers/mfd/88pm80x.c       |    2 +-
 include/linux/mfd/88pm80x.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied as well, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/