Skip to contentSkip to conversation

fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

PATCH Superseded Michal Simek 4 participants 5 messages Jul 11, 2012 – Aug 10, 2012 Library code

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

Include arch specific gpio.h instead of asm-generic/gpio.h because several architectures (Microblaze, Blackfin, Nios2, OpenRISC) define gpio functions in header file.
asm-generic/gpio.h can be included in arch specific gpio.h (For example: ARM)

---
v2: Use only arch specific gpio.h
Remove commentary

---
 lib/fdtdec.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
lib/fdtdec.c +1 -2
index cc09e06..af17ac1 100644
@@ -24,8 +24,7 @@
 #include <libfdt.h>
 #include <fdtdec.h>
 
-/* we need the generic GPIO interface here */
-#include <asm-generic/gpio.h>
+#include <asm/gpio.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v2 1/1 fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

Quoted 5 lines · On Wednesday 11 July 2012 08:26:38 Michal Simek wrote:

Include arch specific gpio.h instead of asm-generic/gpio.h because several architectures (Microblaze, Blackfin, Nios2, OpenRISC) define gpio functions in header file.
asm-generic/gpio.h can be included in arch specific gpio.h (For example: ARM)

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120718/fd25106d/attachment.pgp>

#2 lore raw

PATCH v2 1/1 fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

Quoted 1 line · Mike Frysinger

Simon: Are you OK with this patch?

Thanks,
Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#3 lore raw

PATCH v2 1/1 fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

Him

Quoted 6 lines · Michal Simek
Quoted 2 lines · Mike Frysinger

Simon: Are you OK with this patch?

Yes, thanks.

Quoted 10 lines

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

#4 lore raw

PATCH v2 1/1 fdt: Include arch specific gpio.h instead of asm-generic/gpio.h

In reply to Michal Simek

Hi,

Quoted 9 lines · On Wed, 11 Jul 2012 14:26:38 +0200 Michal Simek <[email protected]> wrote:

Include arch specific gpio.h instead of asm-generic/gpio.h because several architectures (Microblaze, Blackfin, Nios2, OpenRISC) define gpio functions in header file.
asm-generic/gpio.h can be included in arch specific gpio.h (For example: ARM)

Quoted 6 lines

---
v2: Use only arch specific gpio.h
Remove commentary

---
 lib/fdtdec.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

applied to my staging branch, thanks!

Anatolij