Skip to contentSkip to conversation

drm/i915: mask tiled bit when updating ILK sprites

PATCH In review Ander Conselvan de Oliveira 3 participants 3 messages Jul 13, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: mask tiled bit when updating ILK sprites

From: Ander Conselvan de Oliveira <[email protected]>

Or going from tiled to untiled may break.

---
 drivers/gpu/drm/i915/intel_sprite.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_sprite.c +1 -0
index 1a1483b..cc8df4d 100644
@@ -234,6 +234,7 @@ ilk_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
 	dvscntr &= ~DVS_PIXFORMAT_MASK;
 	dvscntr &= ~DVS_RGB_ORDER_XBGR;
 	dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
+	dvscntr &= ~DVS_TILED;
 
 	switch (fb->pixel_format) {
 	case DRM_FORMAT_XBGR8888:
Signature · 1 line
1.7.4.1
#2 lore raw
Quoted 7 lines · Chris Wilson
Quoted 5 lines · Ander Conselvan de Oliveira

From: Ander Conselvan de Oliveira <[email protected]>

Or going from tiled to untiled may break.

Queued for -next, thanks for the patch. For some odd reason I've thought I've reviewed the other sprite implementations when I've merged Jesse's identical fix for ivb. But alas, I've failed, thanks for catching this. -Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48