staging/wlan-ng: use kzalloc rather using kmalloc at create_wlan

PATCH New Devendra Naga 1 participant 1 message Jul 14, 2012 Staging

lore

Share & tools

lore

Devendra Naga

author

2012-07-14 07:42 UTC #0 lore raw

PATCH 1/1 staging/wlan-ng: use kzalloc rather using kmalloc at create_wlan

instead we would have used kzalloc, so our memory which is allocated will be set to 0.

codepath:

the code path here is prism2sta_probe_usb, calling when ever usb-dev id and usb-vendor id e.t.c matches with what ever present in the MODULE_DEVICE_TABLE,

and in prism2sta_probe_usb , we call create_wlan, and its called nowhere else...

Signed-off-by Devendra Naga <[email protected]>

---
 drivers/staging/wlan-ng/prism2sta.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

drivers/staging/wlan-ng/prism2sta.c +2 -6

index 417aea5..1dfd9aa 100644
@@ -1947,8 +1947,8 @@ static wlandevice_t *create_wlan(void)
 	hfa384x_t *hw = NULL;
 
 	/* Alloc our structures */
-	wlandev = kmalloc(sizeof(wlandevice_t), GFP_KERNEL);
-	hw = kmalloc(sizeof(hfa384x_t), GFP_KERNEL);
+	wlandev = kzalloc(sizeof(wlandevice_t), GFP_KERNEL);
+	hw = kzalloc(sizeof(hfa384x_t), GFP_KERNEL);
 
 	if (!wlandev || !hw) {
 		printk(KERN_ERR "%s: Memory allocation failure.\n", dev_info);

@@ -1957,10 +1957,6 @@ static wlandevice_t *create_wlan(void)
 		return NULL;
 	}
 
-	/* Clear all the structs */
-	memset(wlandev, 0, sizeof(wlandevice_t));
-	memset(hw, 0, sizeof(hfa384x_t));
-
 	/* Initialize the network device object. */
 	wlandev->nsdname = dev_info;
 	wlandev->msdstate = WLAN_MSD_HWPRESENT_PENDING;

Signature · 1 line

1.7.9.5