Skip to contentSkip to conversation

rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails

PATCH New Devendra Naga 1 participant 1 message Jul 18, 2012 Real time clock (RTC)

lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH 1/3 rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails

At the probe we are assigning ret to return value of PTR_ERR right after the rtc_register_driver, as we would have done it in the if (IS_ERR(ptr)) check, since the function fails and goes inside that case

Signed-off-by Devendra Naga <[email protected]>
---
 drivers/rtc/rtc-88pm80x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-88pm80x.c +1 -1
index a2f956d..7e050b4 100644
@@ -314,8 +314,8 @@ static int __devinit pm80x_rtc_probe(struct platform_device *pdev)
 
 	info->rtc_dev = rtc_device_register("88pm80x-rtc", &pdev->dev,
 					    &pm80x_rtc_ops, THIS_MODULE);
-	ret = PTR_ERR(info->rtc_dev);
 	if (IS_ERR(info->rtc_dev)) {
+		ret = PTR_ERR(info->rtc_dev);
 		dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
 		goto out_rtc;
 	}
Signature · 1 line
1.7.0.4