ASoC: dapm: Fix _PRE and _POST events for DAPM performance improvements
PATCH 1/1 ASoC: dapm: Fix _PRE and _POST events for DAPM performance improvements
Ever since the DAPM performance improvements we've been marking all widgets as not dirty after each DAPM run. Since _PRE and _POST events aren't part of the DAPM graph this has rendered them non-functional, they will never be marked dirty again and thus will never be run again.
Fix this by skipping them when marking widgets as not dirty.
--- sound/soc/soc-dapm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
sound/soc/soc-dapm.c +9 -1
@@ -1597,7 +1597,15 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event) }list_for_each_entry (w, &card->widgets, list) { -list_del_init (&w->dirty); +switch (w->id) { +case snd_soc_dapm_pre: +case snd_soc_dapm_post: +/* These widgets always need to be powered */ +break ; +default : +list_del_init (&w->dirty); +break ; + }if (w->power) { d = w->dapm;
Signature · 1 line
1.7.10.4
Quoted 8 lines · Mark Brown
Ever since the DAPM performance improvements we've been marking all widgets as not dirty after each DAPM run. Since
_PREand_POSTevents aren't part of the DAPM graph this has rendered them non-functional, they will never be marked dirty again and thus will never be run again.Fix this by skipping them when marking widgets as not dirty.
Signed-off-by Mark Brown <[email protected]>