Skip to contentSkip to conversation

systemd_git.bb: Dont inherit vala and gitpkgv

PATCH In review Khem Raj 3 participants 7 messages Jul 21, 2012 – Jul 22, 2012

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 systemd_git.bb: Dont inherit vala and gitpkgv

In an effort to use meta-systemd without meta-oe
layer (purely on OE-Core) I ran into these classes not being there in OE-Core

---
 meta-systemd/recipes-core/systemd/systemd_git.bb |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
meta-systemd/recipes-core/systemd/systemd_git.bb +5 -5
index 9cbdd76..6ae9abb 100644
@@ -15,13 +15,13 @@ SERIAL_CONSOLE ?= "115200 /dev/ttyS0"
 
 SECTION = "base/shell"
 
-inherit gitpkgv
-PKGV = "v${GITPKGVTAG}"
+#inherit gitpkgv
+#PKGV = "v${GITPKGVTAG}"
 
-PV = "git"
-PR = "r2"
+PV = "git${SRCPV}"
+PR = "r3"
 
-inherit useradd pkgconfig autotools vala perlnative
+inherit useradd pkgconfig autotools perlnative
 
 SRCREV = "cd96b3b86abb4a88cac2722bdfb6e5d4413f6831"
 
Signature · 1 line
1.7.5.4
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 21-07-12 21:41, Khem Raj schreef:

Quoted 2 lines

In an effort to use meta-systemd without meta-oe layer (purely on OE-Core) I ran into these classes not being there in OE-Core

The vala one isn't needed anymore, the GUI bits are a seperate project now, but the gitpkgv needs to stay. We can symlink the class from meta-oe into meta-systemd

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQC6fpMkyGM64RGpERAq6pAKCr+1GPYZLT4WeM0CZP+Amt/8e1kwCeLbUO YgNIUkEEms/mtTUB2Qat2Sg=
=oLXc
-----END PGP SIGNATURE-----

author
#2 lore raw
Quoted 4 lines · Koen Kooi

The vala one isn't needed anymore, the GUI bits are a seperate project now, but the gitpkgv needs to stay. We can symlink the class from meta-oe into meta-systemd

why do we need gitpkgv it creates unnecessary dependency on meta-oe it would be better
to avoid it. What are downsides of not using gitpkgv ?

#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-07-12 18:35, Khem Raj schreef:

Quoted 9 lines
Quoted 4 lines · Koen Kooi

The vala one isn't needed anymore, the GUI bits are a seperate project now, but the gitpkgv needs to stay. We can symlink the class from meta-oe into meta-systemd

why do we need gitpkgv it creates unnecessary dependency on meta-oe it would be better to avoid it. What are downsides of not using gitpkgv ?

Right now we automatically get the proper version, removing gitpkgv would be a regression. Why not symlink the class into meta-systemd?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQDDztMkyGM64RGpERAvIzAJ41okNJo/onPU8pmnyBj+Rfge4KMACfUFBU 0rD0duRR+5QpyI9094ommXc=
=oJ9z
-----END PGP SIGNATURE-----

author
#4 lore raw
Quoted 2 lines · Koen Kooi

Right now we automatically get the proper version, removing gitpkgv would be a regression. Why not symlink the class into meta-systemd?

symlink would work since both layers are in same repo but logically it may not be right thing
secondly if one day we would want to make systemd as default init system in OE-Core then
either gitpkgv has to go into OE-Core or it be dropped. I think with advent of autopr these all
may become less important in time anyway.

#5 lore raw
In reply to Koen Kooi
Quoted 6 lines · On Sunday 22 July 2012 09:12:41 Koen Kooi wrote:

Op 21-07-12 21:41, Khem Raj schreef:

Quoted 2 lines

In an effort to use meta-systemd without meta-oe layer (purely on OE-Core) I ran into these classes not being there in OE-Core

The vala one isn't needed anymore, the GUI bits are a seperate project now, but the gitpkgv needs to stay.

Why? I can't see how gitpkgv has anything to do with systemd...

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#6 lore raw

Op 22 jul. 2012, om 18:38 heeft Paul Eggleton het volgende geschreven:

Quoted 9 lines · On Sunday 22 July 2012 09:12:41 Koen Kooi wrote:
Quoted 6 lines

Op 21-07-12 21:41, Khem Raj schreef:

Quoted 2 lines

In an effort to use meta-systemd without meta-oe layer (purely on OE-Core) I ran into these classes not being there in OE-Core

The vala one isn't needed anymore, the GUI bits are a seperate project now, but the gitpkgv needs to stay.

Why? I can't see how gitpkgv has anything to do with systemd...

Because it's used to set PV automatically:

inherit gitpkgv
PKGV = "v${GITPKGVTAG}"