af_packet: use define instead of constant

PATCH Applied Daniel Borkmann 2 participants 2 messages Aug 20, 2012 – Aug 23, 2012

Subsystems (3)

Networking Network drivers Packet sockets

lore

Share & tools

lore

Daniel Borkmann

author

2012-08-20 13:34 UTC #0 lore raw

PATCH 1/1 af_packet: use define instead of constant

Instead of using a hard-coded value for the status variable, it would make the code more readable to use its destined define from linux/if_packet.h.

Signed-off-by [email protected]

---
 net/packet/af_packet.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

net/packet/af_packet.c +3 -2

index 226b2cd..3ee372a 100644
@@ -855,7 +855,8 @@ static void prb_fill_vlan_info(struct tpacket_kbdq_core *pkc,
 		ppd->hv1.tp_vlan_tci = vlan_tx_tag_get(pkc->skb);
 		ppd->tp_status = TP_STATUS_VLAN_VALID;
 	} else {
-		ppd->hv1.tp_vlan_tci = ppd->tp_status = 0;
+		ppd->hv1.tp_vlan_tci = 0;
+		ppd->tp_status = TP_STATUS_AVAILABLE;
 	}
 }

@@ -1943,7 +1944,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg)
 	int tp_len, size_max;
 	unsigned char *addr;
 	int len_sum = 0;
-	int status = 0;
+	int status = TP_STATUS_AVAILABLE;
 	int hlen, tlen;
 
 	mutex_lock(&po->pg_vec_lock);

David Miller

maintainer Applied

2012-08-23 05:58 UTC #1 lore raw

From: Daniel Borkmann <[email protected]>
Date: Mon, 20 Aug 2012 15:34:03 +0200

Quoted 4 lines

Instead of using a hard-coded value for the status variable, it would make the code more readable to use its destined define from linux/if_packet.h.
Signed-off-by [email protected]

Applied.