fuse: mark variables uninitialized
PATCH 1/1 fuse: mark variables uninitialized
gcc 4.6.3 complains about uninitialized variables in fs/fuse/control.c:
CC fs/fuse/control.ofs/fuse/control.c: In function ‘fuse_conn_congestion_threshold_write’:fs/fuse/control.c:165:29: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized] fs/fuse/control.c: In function ‘fuse_conn_max_background_write’:fs/fuse/control.c:128:23: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
fuse_conn_limit_write() will always return non-zero unless the &val is modified, so the warning is misleading. Let the compiler know about it by marking 'val' with 'uninitialized_var'.
--- fs/fuse/control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/fuse/control.c +2 -2
@@ -117,7 +117,7 @@ static ssize_t fuse_conn_max_background_write(struct file *file,const char __user *buf, size_t count, loff_t *ppos) { - unsigned val; + unsigned uninitialized_var(val);ssize_t ret; ret = fuse_conn_limit_write(file, buf, count, ppos, &val,
@@ -154,7 +154,7 @@ static ssize_t fuse_conn_congestion_threshold_write(struct file *file,const char __user *buf, size_t count, loff_t *ppos) { - unsigned val; + unsigned uninitialized_var(val);ssize_t ret; ret = fuse_conn_limit_write(file, buf, count, ppos, &val,
Signature · 1 line
1.7.11.4
Miklos Szeredi
AppliedQuoted 11 lines · Daniel Mack
gcc 4.6.3 complains about uninitialized variables in
fs/fuse/control.c:CC
fs/fuse/control.ofs/fuse/control.c: In function ‘fuse_conn_congestion_threshold_write’:fs/fuse/control.c:165:29: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]fs/fuse/control.c: In function ‘fuse_conn_max_background_write’:fs/fuse/control.c:128:23: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
fuse_conn_limit_write()will always return non-zero unless the &val is modified, so the warning is misleading. Let the compiler know about it by marking 'val' with 'uninitialized_var'.
Thanks, applied.
Miklos