Skip to contentSkip to conversation

ASoC: Revert 'ASoC: imx-ssi: Remove mono support'

PATCH Applied Fabio Estevam 2 participants 3 messages Sep 6, 2012 – Oct 1, 2012 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ASoC: Revert 'ASoC: imx-ssi: Remove mono support'

From: Javier Martin <[email protected]>

Revert 0865a75(ASoC: imx-ssi: Remove mono support).

The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards. Furthermore, after applying this patch sound in Visstrim_M10 is played at slower rates.

---
 sound/soc/fsl/imx-ssi.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
sound/soc/fsl/imx-ssi.c +2 -3
index 7074ae6..3c520c4 100644
@@ -380,14 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
 static struct snd_soc_dai_driver imx_ssi_dai = {
 	.probe = imx_ssi_dai_probe,
 	.playback = {
-		/* The SSI does not support monaural audio. */
-		.channels_min = 2,
+		.channels_min = 1,
 		.channels_max = 2,
 		.rates = SNDRV_PCM_RATE_8000_96000,
 		.formats = SNDRV_PCM_FMTBIT_S16_LE,
 	},
 	.capture = {
-		.channels_min = 2,
+		.channels_min = 1,
 		.channels_max = 2,
 		.rates = SNDRV_PCM_RATE_8000_96000,
 		.formats = SNDRV_PCM_FMTBIT_S16_LE,
Signature · 1 line
1.7.9.5
Applied
#1 lore raw
Quoted 7 lines · Fabio Estevam

From: Javier Martin <[email protected]>

Revert 0865a75(ASoC: imx-ssi: Remove mono support).

The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards. Furthermore, after applying this patch sound in Visstrim_M10 is played at slower rates.

Applied, thanks.

A message that is not in the archive (sent off-list or not yet received): CACKLOr3VDxDQb30aqNOhEHtc7AAFUZw07_BAwrk3yXqmBfHyxQ@mail.gmail.com

#3 lore raw
Quoted 3 lines · javier Martin

Hi Mark, Fabio,
this patch should be applied as a fix to stable 3.6 too. Otherwise, audio for Visstrim M10 will continue broken in 3.6.

You need to tell the stable team about this, then.