hob: format error messages properly

PATCH Applied Paul Eggleton 2 participants 2 messages Sep 11, 2012 – Sep 14, 2012

Share & tools

Paul Eggleton

author

2012-09-11 11:13 UTC #0 lore raw

PATCH 1/1 hob: format error messages properly

Error messages that use arguments need to be formatted properly, or we don't get the full message. Use a formatter to do this when an error occurs.

Partial fix for [YOCTO #2983].

Signed-off-by Paul Eggleton <[email protected]>

---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

bitbake/lib/bb/ui/crumbs/hobeventhandler.py +3 -1

index dac2f74..35cbded 100644
@@ -177,7 +177,9 @@ class HobHandler(gobject.GObject):
 
         elif isinstance(event, logging.LogRecord):
             if event.levelno >= logging.ERROR:
-                self.error_msg += event.msg + '\n'
+                formatter = bb.msg.BBLogFormatter()
+                formatter.format(event)
+                self.error_msg += event.message + '\n'
 
         elif isinstance(event, bb.event.TargetsTreeGenerated):
             self.current_phase = "data generation"

Signature · 1 line

1.7.9.5

Richard Purdie

Applied

2012-09-14 08:40 UTC #1 lore raw

Quoted 10 lines · Paul Eggleton

Error messages that use arguments need to be formatted properly, or we don't get the full message. Use a formatter to do this when an error occurs.
Partial fix for [YOCTO #2983].
Signed-off-by Paul Eggleton <[email protected]>
---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Merged to master, thanks.

Richard