linux-yocto: x32 and features update

PATCH In review Bruce Ashfield 4 participants 11 messages Sep 11, 2012 – Sep 12, 2012

lore

Share & tools

lore

Bruce Ashfield

author

2012-09-11 15:30 UTC #0 lore raw

cover linux-yocto: x32 and features update

Richard/Saul,

This is my part of a change that Saul will complete with the addition of x32 as a machine override for x86 BSPs that have x32 as their tuning.

With this change, the x32 configuration fragment will be appended to any give x86 BSP configuration and it will support the userspace tuning.

Also bundled with this change is an associated change to not have the linux-yocto recipes directly assign KERNEL_FEATURES, but instead always append to the variable. This allows features like x32 to be tested by setting the variable in a local.conf or machine .conf file.

Cheers,

Bruce

cc Saul Wold <[email protected]>

The following changes since commit cc8bfedabfe61a0e06a8a8199f8c0fce4738260a:

linux-yocto/3.4: v3.4.10 and uprobes/kprobes configuration updates (2012-09-10 14:05:15 -0400)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib zedd/x32
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/x32

Bruce Ashfield (2):
linux-yocto*: append to KERNEL_FEATURES instead of assigning linux-yocto/3.4: add x32 configuration fragment and tuning hook

 meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb |    5 +++--
 meta/recipes-kernel/linux/linux-yocto_3.0.bb    |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.2.bb    |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.4.bb    |    5 +++--
 6 files changed, 10 insertions(+), 8 deletions(-)

Signature · 1 line

1.7.5.4

Bruce Ashfield

author

2012-09-11 15:30 UTC #1 lore raw

PATCH 1/2 linux-yocto*: append to KERNEL_FEATURES instead of assigning

It is sometimes useful for KERNEL_FEATURES to be set in a machine or other configuration file. The linux-yocto recipes currently initialize the variable, which clobbers any values set by .conf files.

Appending to the variables allows these settings to propagate to the kernel configuration, while maintaining the existing set of added kernel features.

Signed-off-by Bruce Ashfield <[email protected]>

---
 meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.0.bb    |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.2.bb    |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.4.bb    |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb +1 -1

index a16b549..0cdc7c0 100644
@@ -22,7 +22,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0.git;protocol=git;bareclone
 COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
 
 # Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append = " features/taskstats"
 KERNEL_FEATURES_append_qemux86 = " cfg/sound"
 KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"

meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb +1 -1

index 05362ef..a3900ce 100644
@@ -23,7 +23,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2.git;protocol=git;bareclone
 COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
 
 # Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = "features/netfilter"
 KERNEL_FEATURES_append = " features/taskstats"
 KERNEL_FEATURES_append_qemux86 = " cfg/sound"
 KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"

meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1

index 3b36378..4fd3845 100644
@@ -23,7 +23,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;bareclone
 COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
 
 # Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append = " features/taskstats"
 KERNEL_FEATURES_append_qemux86 = " cfg/sound"
 KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"

meta/recipes-kernel/linux/linux-yocto_3.0.bb +1 -1

index d16cdf0..e917beb 100644
@@ -27,7 +27,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0;protocol=git;bareclone=1;b
 COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append = " features/taskstats"
 KERNEL_FEATURES_append_qemux86 = " cfg/sound"
 KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"

meta/recipes-kernel/linux/linux-yocto_3.2.bb +1 -1

index ba4b536..45414d5 100644
@@ -27,7 +27,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2;protocol=git;bareclone=1;b
 COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
-KERNEL_FEATURES="features/netfilter"
+KERNEL_FEATURES_append=" features/netfilter"
 KERNEL_FEATURES_append=" features/taskstats"
 KERNEL_FEATURES_append_qemux86=" cfg/sound"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound"

meta/recipes-kernel/linux/linux-yocto_3.4.bb +1 -1

index 7258cba..59ad4b2 100644
@@ -24,6 +24,6 @@ COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
 KERNEL_REVISION_CHECKING=""
-KERNEL_FEATURES="features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append_qemux86=" cfg/sound"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound"

Signature · 1 line

1.7.5.4

Bruce Ashfield

author

2012-09-11 15:30 UTC #2 lore raw

PATCH 2/2 linux-yocto/3.4: add x32 configuration fragment and tuning hook

In reply to Bruce Ashfield

When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.

This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.

cc Saul Wold <[email protected]>

Signed-off-by Bruce Ashfield <[email protected]>

---
 meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb |    3 ++-
 meta/recipes-kernel/linux/linux-yocto_3.4.bb    |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +2 -1

index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
 SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
 SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
 
 PR = "${INC_PR}.0"
 PV = "${LINUX_VERSION}+git${SRCPV}"

@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append = " features/taskstats"
 KERNEL_FEATURES_append_qemux86 = " cfg/sound"
 KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
\ No newline at end of file

meta/recipes-kernel/linux/linux-yocto_3.4.bb +2 -1

index 59ad4b2..bcd1292 100644
@@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?= "b9a720ca38d298ed457f37d099c85771f9164b19"
 SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
 SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
 SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
-SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
 
 SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"

@@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
 KERNEL_FEATURES_append = " features/netfilter"
 KERNEL_FEATURES_append_qemux86=" cfg/sound"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"

Signature · 1 line

1.7.5.4

Saul Wold

2012-09-11 15:45 UTC #3 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 27 lines · Bruce Ashfield

When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
  meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb |    3 ++-
  meta/recipes-kernel/linux/linux-yocto_3.4.bb    |    3 ++-
  2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
  SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
  SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
 
  PR = "${INC_PR}.0"
  PV = "${LINUX_VERSION}+git${SRCPV}"

meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb KERNEL_FEATURES_append = " features/netfilter" · line 30

Quoted 4 lines

meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -0

@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
  KERNEL_FEATURES_append = " features/taskstats"
  KERNEL_FEATURES_append_qemux86 = " cfg/sound"
  KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"

Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.

Sau!

Quoted 20 lines

\ No newline at end of file

meta/recipes-kernel/linux/linux-yocto_3.4.bb +2 -1

index 59ad4b2..bcd1292 100644
@@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?= "b9a720ca38d298ed457f37d099c85771f9164b19"
  SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
  SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
  SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
-SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
 
  SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"

@@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
  KERNEL_FEATURES_append = " features/netfilter"
  KERNEL_FEATURES_append_qemux86=" cfg/sound"
  KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"

Bruce Ashfield

author

2012-09-11 15:51 UTC #4 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 26 lines · Saul Wold

Quoted 25 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"

Quoted 10 lines

Quoted 7 lines
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.

Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.

Bruce

Quoted 28 lines

Sau!
Quoted 24 lines
\ No newline at end of file
meta/recipes-kernel/linux/linux-yocto_3.4.bb +0 -0
index 59ad4b2..bcd1292 100644
@@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?=
"b9a720ca38d298ed457f37d099c85771f9164b19" SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844" SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844" SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
meta/recipes-kernel/linux/linux-yocto_3.4.bb +1 -1
-SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
meta/recipes-kernel/linux/linux-yocto_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append_qemux86=" cfg/sound"
KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"

Saul Wold

2012-09-11 15:53 UTC #5 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 38 lines · Bruce Ashfield

Quoted 26 lines · Saul Wold
Quoted 25 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
Quoted 10 lines
Quoted 7 lines
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.

Quoted 3 lines

Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.

Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.

Sau!

Quoted 39 lines

Bruce
Quoted 22 lines
Sau!
Quoted 19 lines
\ No newline at end of file
meta/recipes-kernel/linux/linux-yocto_3.4.bb +0 -0
index 59ad4b2..bcd1292 100644
@@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?=
"b9a720ca38d298ed457f37d099c85771f9164b19" SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844" SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844" SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
meta/recipes-kernel/linux/linux-yocto_3.4.bb +1 -1
-SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
Quoted 7 lines
Quoted 6 lines
meta/recipes-kernel/linux/linux-yocto_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append_qemux86=" cfg/sound"
KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Richard Purdie

2012-09-11 16:11 UTC #6 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 39 lines · Saul Wold

Quoted 38 lines · Bruce Ashfield
Quoted 36 lines · Saul Wold
Quoted 28 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
Quoted 4 lines
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.

Quoted 6 lines

Quoted 3 lines
Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.
Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.

No, it doesn't.

What we need here is:

-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"

which is simple, effective and to the point. If we start needing lots of these, we can look at an x32 override but right now I don't see the need.

Cheers,

Richard

Saul Wold

2012-09-11 16:20 UTC #7 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 52 lines · Richard Purdie

Quoted 39 lines · Saul Wold
Quoted 38 lines · Bruce Ashfield
Quoted 36 lines · Saul Wold
Quoted 28 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
Quoted 4 lines
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.
Quoted 6 lines
Quoted 3 lines
Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.
Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.
No, it doesn't.
What we need here is:

Review

Quoted 2 lines

(quoted diff) +1 -1

-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"

No, this would then only address the qemu machine, what about all the HW BSP that might want it, they would need to add this same line. If I add the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32, then any x86-64 BSP can just enable that TUNE, isn't that the point of the machine config tuning?

Quoted 4 lines

which is simple, effective and to the point. If we start needing lots of these, we can look at an x32 override but right now I don't see the need.

And it does not have to be an x32 override, we just set it in the arch-ia32.inc file where we define that TUNE.

That seems the best way.

Sau!

Quoted 11 lines

Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Richard Purdie

2012-09-12 12:38 UTC #8 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 52 lines · Saul Wold

Quoted 51 lines · Richard Purdie
Quoted 39 lines · Saul Wold
Quoted 38 lines · Bruce Ashfield
Quoted 36 lines · Saul Wold
Quoted 28 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
Quoted 4 lines
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.
Quoted 6 lines
Quoted 3 lines
Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.
Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.
No, it doesn't.
What we need here is:

Quoted 8 lines

Review
Quoted 3 lines
(quoted diff) +1 -1
-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
No, this would then only address the qemu machine, what about all the HW BSP that might want it, they would need to add this same line. If I add the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32, then any x86-64 BSP can just enable that TUNE, isn't that the point of the machine config tuning?

It is the point, however, the key part of this you're ignoring is that the kernel fragment management only happens for linux-yocto. Only the linux-yocto recipe supports the KERNEL_FEATURES mechanism.

The arch-ia32.inc file and any machine config *cannot* depend on linux-yocto.

So this glue belongs in linux-yocto. I agree is suboptimal for people not using it but such is life, there isn't any generic mechanism we can place this into.

Quoted 8 lines

Quoted 4 lines
which is simple, effective and to the point. If we start needing lots of these, we can look at an x32 override but right now I don't see the need.
And it does not have to be an x32 override, we just set it in the arch-ia32.inc file where we define that TUNE.
That seems the best way.

Its not. See above.

Cheers,

Richard

Bruce Ashfield

2012-09-12 13:16 UTC #9 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 66 lines · Richard Purdie

Quoted 52 lines · Saul Wold
Quoted 51 lines · Richard Purdie
Quoted 39 lines · Saul Wold
Quoted 38 lines · Bruce Ashfield
Quoted 36 lines · Saul Wold
Quoted 28 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
Quoted 4 lines
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.
Quoted 6 lines
Quoted 3 lines
Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.
Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.
No, it doesn't.
What we need here is:
Quoted 8 lines
Review
Quoted 3 lines
(quoted diff) +1 -1
-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
No, this would then only address the qemu machine, what about all the HW BSP that might want it, they would need to add this same line. If I add the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32, then any x86-64 BSP can just enable that TUNE, isn't that the point of the machine config tuning?
It is the point, however, the key part of this you're ignoring is that the kernel fragment management only happens for linux-yocto. Only the linux-yocto recipe supports the KERNEL_FEATURES mechanism.

Quoted 6 lines

The arch-ia32.inc file and any machine config *cannot* depend on linux-yocto.
So this glue belongs in linux-yocto. I agree is suboptimal for people not using it but such is life, there isn't any generic mechanism we can place this into.

linux-yocto it is, I've respun the patches to include the TUNE_FEATURES check and pushed them to poky-contrib zedd/x32:

7aeb32 linux-yocto/3.4: add x32 configuration fragment d34a34c linux-yocto*: append to KERNEL_FEATURES instead of assigning

I don't have a x32 build handy, but I assume Saul will take them for a spin.

If you want a full resend of the series, shout and I'll git send-email them out.

Cheers,

Bruce

Quoted 21 lines

Quoted 9 lines
Quoted 5 lines
which is simple, effective and to the point. If we start needing lots of these, we can look at an x32 override but right now I don't see the need.
And it does not have to be an x32 override, we just set it in the arch-ia32.inc file where we define that TUNE.
That seems the best way.
Its not. See above.
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 2 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Richard Purdie

2012-09-12 14:01 UTC #10 lore raw

Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook

Quoted 80 lines · Bruce Ashfield

Quoted 66 lines · Richard Purdie
Quoted 52 lines · Saul Wold
Quoted 51 lines · Richard Purdie
Quoted 39 lines · Saul Wold
Quoted 38 lines · Bruce Ashfield
Quoted 36 lines · Saul Wold
Quoted 28 lines · Bruce Ashfield
When x32 is the tuning for a x86 MACHINE, the kernel should also have CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the KERNEL_FEATURES when x32 is the tuning for a given machine.
cc Saul Wold <[email protected]>
Signed-off-by Bruce Ashfield <[email protected]>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++- meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
index 4fd3845..156fb93 100644
@@ -10,7 +10,7 @@ KMETA = "meta"
 
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0" SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +1 -1
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb +0 -0
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
Quoted 4 lines
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism you talked about to go from a .conf file.
Quoted 6 lines
Quoted 3 lines
Works for me. The meta change is staged and pushed out, I'll update this patch to not have the KERNEL_FEATURES portion.
Thanks, see my other email to RP, since x32 is a feature that any x86-64 machine might want to enable based on the DEFAULTTUNE it makes more sense to be in the machine config includes.
No, it doesn't.
What we need here is:
Quoted 8 lines
Review
Quoted 3 lines
(quoted diff) +1 -1
-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
No, this would then only address the qemu machine, what about all the HW BSP that might want it, they would need to add this same line. If I add the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32, then any x86-64 BSP can just enable that TUNE, isn't that the point of the machine config tuning?
It is the point, however, the key part of this you're ignoring is that the kernel fragment management only happens for linux-yocto. Only the linux-yocto recipe supports the KERNEL_FEATURES mechanism.
Quoted 6 lines
The arch-ia32.inc file and any machine config *cannot* depend on linux-yocto.
So this glue belongs in linux-yocto. I agree is suboptimal for people not using it but such is life, there isn't any generic mechanism we can place this into.
:)
linux-yocto it is, I've respun the patches to include the TUNE_FEATURES check and pushed them to poky-contrib zedd/x32:

Quoted 6 lines

7aeb32 linux-yocto/3.4: add x32 configuration fragment d34a34c linux-yocto*: append to KERNEL_FEATURES instead of assigning
I don't have a x32 build handy, but I assume Saul will take them for a spin.
If you want a full resend of the series, shout and I'll git send-email them out.

I've merged this, thanks. I'm assuming Saul will test the end result.

Cheers,

Richard