Skip to contentSkip to conversation

HID: lenovo-tpkbd: Fix memory leak in tpkbd_remove_tp()

PATCH Applied Axel Lin 3 participants 3 messages Sep 13, 2012 – Sep 17, 2012 HID

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 HID: lenovo-tpkbd: Fix memory leak in tpkbd_remove_tp()

We need to kfree names for led_mute and led_micmute in tpkbd_remove_tp().

---
 drivers/hid/hid-lenovo-tpkbd.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-lenovo-tpkbd.c +2 -0
index 77d2df0..60c4e1e 100644
@@ -519,6 +519,8 @@ static void tpkbd_remove_tp(struct hid_device *hdev)
 	led_classdev_unregister(&data_pointer->led_mute);
 
 	hid_set_drvdata(hdev, NULL);
+	kfree(data_pointer->led_micmute.name);
+	kfree(data_pointer->led_mute.name);
 	kfree(data_pointer);
 }
 
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Thu, 13 Sep 2012 13:25:12 +0800 Axel Lin <[email protected]> wrote:

We need to kfree names for led_mute and led_micmute in tpkbd_remove_tp().

Quoted 17 lines
---
 drivers/hid/hid-lenovo-tpkbd.c |    2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/hid/hid-lenovo-tpkbd.c index 77d2df0..60c4e1e 100644

drivers/hid/hid-lenovo-tpkbd.c +2 -0
@@ -519,6 +519,8 @@ static void tpkbd_remove_tp(struct hid_device
 *hdev) led_classdev_unregister(&data_pointer->led_mute);
 
 	hid_set_drvdata(hdev, NULL);
+	kfree(data_pointer->led_micmute.name);
+	kfree(data_pointer->led_mute.name);
 	kfree(data_pointer);
 }
 
Applied
#2 lore raw
Quoted 9 lines · Bernhard Seibold
Quoted 4 lines · On Thu, 13 Sep 2012 13:25:12 +0800 Axel Lin <[email protected]> wrote:

We need to kfree names for led_mute and led_micmute in tpkbd_remove_tp().

Applied, thanks.

Quoted 18 lines
Quoted 17 lines
---
 drivers/hid/hid-lenovo-tpkbd.c |    2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/hid/hid-lenovo-tpkbd.c index 77d2df0..60c4e1e 100644

drivers/hid/hid-lenovo-tpkbd.c +2 -0
@@ -519,6 +519,8 @@ static void tpkbd_remove_tp(struct hid_device
 *hdev) led_classdev_unregister(&data_pointer->led_mute);
 
 	hid_set_drvdata(hdev, NULL);
+	kfree(data_pointer->led_micmute.name);
+	kfree(data_pointer->led_mute.name);
 	kfree(data_pointer);
 }
 
Signature · 2 lines
Jiri Kosina
SUSE Labs