add floating point and sse to mini-os
PATCH 7/8 add floating point and sse to mini-os
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
(quoted diff) +0 -0
b/extras/mini-os/arch/x86/setup.c
extras/mini-os/arch/x86/setup.c +20 -0
@@ -74,9 +74,28 @@ shared_info_t *map_shared_info(unsigned long pa)return (shared_info_t *)shared_info; } +static inline void fpu_init (void ) { + asmvolatile ("fninit" ); +} + +#ifdef __SSE__ +static inline void sse_init (void ) { +unsigned long status =0x1f80 ; + asmvolatile ("ldmxcsr %0" : :"m" (status)); +} +#else +#define sse_init () +#endif +void arch_init (start_info_t *si) { +/*Initialize floating point unit */ +fpu_init (); + +/* Initialize SSE */ +sse_init (); +/* Copy the start_info struct to a globally-accessible area. */ /* WARN: don't do printk before here, it uses information from shared_info. Use xprintk instead. */
@@ -99,6 +118,7 @@ arch_init(start_info_t *si) (unsigned long)failsafe_callback, 0);#endif + }void
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 5 lines · Matthew Fioravante, le Mon 17 Sep 2012 18:04:47 -0400, a écrit :
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
I don't remember: does xen support optimizing out FPU context switch when a domain does not use the FPU? It might be useful to make FPU initialization optional in that case, to keep context switch faster. Apart from that,
Quoted 9 lines · Samuel Thibault
Quoted 5 lines · Matthew Fioravante, le Mon 17 Sep 2012 18:04:47 -0400, a écrit :
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
I don't remember: does xen support optimizing out FPU context switch when a domain does not use the FPU?
Yes, but using the FPU once at boot shouldn't interfere with that.
Tim.
Quoted 6 lines · Tim Deegan, le Tue 18 Sep 2012 01:03:22 +0100, a écrit :
Quoted 5 lines · Samuel Thibault
Quoted 4 lines · Matthew Fioravante, le Mon 17 Sep 2012 18:04:47 -0400, a écrit :
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed of by: Matthew Fioravante [email protected]
I don't remember: does xen support optimizing out FPU context switch when a domain does not use the FPU?
Yes, but using the FPU once at boot shouldn't interfere with that.
Ah, right, the initialize context isn't restored until FPU is really used. Then it's all OK.
Samuel
Quoted 11 lines · Matthew Fioravante
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
extras/mini-os/arch/x86/setup.c shared_info_t *map_shared_info(unsigned long pa) · line 81
Quoted 8 lines
extras/mini-os/arch/x86/setup.c +5
-0@@ -74,9 +74,28 @@ shared_info_t *map_shared_info(unsigned long pa)return (shared_info_t *)shared_info; } +static inline void fpu_init (void ) { + asmvolatile ("fninit" ); +} + +#ifdef __SSE__
How and when is this symbol defined?
Quoted 6 lines
extras/mini-os/arch/x86/setup.c +6
-0+static inline void sse_init (void ) { +unsigned long status =0x1f80 ; + asmvolatile ("ldmxcsr %0" : :"m" (status)); +} +#else +#define sse_init ()
extras/mini-os/arch/x86/setup.c shared_info_t *map_shared_info(unsigned long pa) · line 97
Quoted 10 lines
extras/mini-os/arch/x86/setup.c +7
-0+#endif +void arch_init (start_info_t *si) { +/*Initialize floating point unit */ +fpu_init (); + +/* Initialize SSE */ +sse_init ();
The indentation here is a bit suspect.
Quoted 14 lines
extras/mini-os/arch/x86/setup.c +2
-0+/* Copy the start_info struct to a globally-accessible area. */ /* WARN: don't do printk before here, it uses information from shared_info. Use xprintk instead. */ @@ -99,6 +118,7 @@ arch_init(start_info_t *si) (unsigned long)failsafe_callback, 0);#endif + }void
Quoted 15 lines · Ian Campbell, le Tue 18 Sep 2012 08:21:18 +0100, a écrit :
Quoted 14 lines · Matthew Fioravante
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
extras/mini-os/arch/x86/setup.c +0
-0@@ -74,9 +74,28 @@ shared_info_t *map_shared_info(unsigned long pa)return (shared_info_t *)shared_info; }
Quoted 7 lines
extras/mini-os/arch/x86/setup.c shared_info_t *map_shared_info(unsigned long pa) · line 81
Quoted 5 lines
extras/mini-os/arch/x86/setup.c +5
-0+static inline void fpu_init (void ) { + asmvolatile ("fninit" ); +} + +#ifdef __SSE__How and when is this symbol defined?
This is defined by the compiler if some -msse is enabled. This is the default on i686/x86_64 at least.
Samuel
Quoted 24 lines · Samuel Thibault
Quoted 15 lines · Ian Campbell, le Tue 18 Sep 2012 08:21:18 +0100, a écrit :
Quoted 14 lines · Matthew Fioravante
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
extras/mini-os/arch/x86/setup.c +0
-0@@ -74,9 +74,28 @@ shared_info_t *map_shared_info(unsigned long pa)return (shared_info_t *)shared_info; }Quoted 7 lines
extras/mini-os/arch/x86/setup.c shared_info_t *map_shared_info(unsigned long pa) · line 81
Quoted 5 lines
extras/mini-os/arch/x86/setup.c +5
-0+static inline void fpu_init (void ) { + asmvolatile ("fninit" ); +} + +#ifdef __SSE__How and when is this symbol defined?
Quoted 2 lines
This is defined by the compiler if some -msse is enabled. This is the default on i686/x86_64 at least.
Do we support processors/compilers without SSE or conversely do we require SSE support?
It sounds like either we need a runtime test or the compile time test is unnecessary.
Ian.
Quoted 25 lines · Ian Campbell, le Tue 18 Sep 2012 08:38:23 +0100, a écrit :
Quoted 24 lines · Samuel Thibault
Quoted 22 lines · Ian Campbell, le Tue 18 Sep 2012 08:21:18 +0100, a écrit :
Quoted 11 lines · Matthew Fioravante
This patch adds floating point and sse support to mini-os by initializing the floating point unit and the see unit during domain boot up.
Signed of by: Matthew Fioravante [email protected]
extras/mini-os/arch/x86/setup.c shared_info_t *map_shared_info(unsigned long pa) · line 81
Quoted 8 lines
extras/mini-os/arch/x86/setup.c +5
-0@@ -74,9 +74,28 @@ shared_info_t *map_shared_info(unsigned long pa)return (shared_info_t *)shared_info; } +static inline void fpu_init (void ) { + asmvolatile ("fninit" ); +} + +#ifdef __SSE__How and when is this symbol defined?
Quoted 8 lines
Quoted 2 lines
This is defined by the compiler if some -msse is enabled. This is the default on i686/x86_64 at least.
Do we support processors/compilers without SSE or conversely do we require SSE support?
It sounds like either we need a runtime test or the compile time test is unnecessary.
If the code is compiled with -msse (and thus __SSE__ defined), the compiler itself can emit sse code, so a runtime test will not be enough to avoid a crash on a non-sse machine.
The compile test is however not strictly needed since the code is provided in assembly. And it might be useful to enable sse anyway in case some -msse code gets pulled. IIRC we only support SSE machines, but I'm not 100% sure.
Samuel