USB: EHCI: Tegra: Fix wrong register definition
PATCH v2 1/1 USB: EHCI: Tegra: Fix wrong register definition
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform.
---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
include/linux/usb/ehci_def.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/usb/ehci_def.h +1 -1
@@ -171,7 +171,7 @@ struct ehci_regs {#define USBMODE_CM_HC (3<<0)/* host controller mode */ #define USBMODE_CM_IDLE (0<<0)/* idle state */ -u32 reserved4[7 ]; +u32 reserved4[6 ];/* Moorestown has some non-standard registers, partially due to the fact that * its EHCI controller has both TT and LPM support. HOSTPCx are extensions to
Signature · 1 line
1.7.3
Greg KH
maintainerQuoted 8 lines · Jim Lin
Fix the issue that EHCI registers, hostpc[0] and
usbmode_ex, are not correctly accessed on Tegra3 platform.Signed-off-by Jim Lin <[email protected]>---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
thanks,
greg k-h
Quoted 10 lines · Greg KH
Quoted 8 lines · Jim Lin
Fix the issue that EHCI registers, hostpc[0] and
usbmode_ex, are not correctly accessed on Tegra3 platform.Signed-off-by Jim Lin <[email protected]>---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
Quoted 6 lines
Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
thanks,
greg k-h
If you have applied v1, that's fine.
V2 is just another simplified change, no hurt.
You can ignore it.
Thanks.
Greg KH
maintainerQuoted 11 lines · Jim Lin
Quoted 10 lines · Greg KH
Quoted 8 lines · Jim Lin
Fix the issue that EHCI registers, hostpc[0] and
usbmode_ex, are not correctly accessed on Tegra3 platform.Signed-off-by Jim Lin <[email protected]>---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
Quoted 7 lines
Quoted 6 lines
Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
thanks,
greg k-h
If you have applied v1, that's fine.
You should have gotten an email from me saying I applied it, did that not go through properly?
thanks,
greg k-h
Quoted 24 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Wednesday, September 19, 2012 4:04 PM
To: Jim Lin
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definitionQuoted 16 lines · Jim Lin
Quoted 15 lines · Greg KH
On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote:
Fix the issue that EHCI registers, hostpc[0] andusbmode_ex, areQuoted 7 lines
not correctly accessed on Tegra3 platform.
Signed-off-by Jim Lin <[email protected]>---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
thanks,
Quoted 8 lines
Quoted 2 lines
Quoted 1 line
greg k-h
If you have applied v1, that's fine.
You should have gotten an email from me saying I applied it, did that not go through properly?
thanks,
greg k-h
Sorry, my mistake, I received that mail and thought still having chance to fine tune.
--
nvpublic
Quoted 17 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Wednesday, September 19, 2012 2:29 PM
To: Jim Lin
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definitionQuoted 8 lines · Jim Lin
Fix the issue that EHCI registers, hostpc[0] and
usbmode_ex, are not correctly accessed on Tegra3 platform.Signed-off-by Jim Lin <[email protected]>---
Changes in v2:
- Modify array size for reserved4[] only.
- Note that defining hostpc[0] is for a variable-length object.
Quoted 5 lines
Didn't I already apply V1 of this patch? Can you now send me a fixup given that the first patch had a problem?
thanks,
greg k-h
If you have applied v1, that's fine.
V2 is just another simplified change, no hurt.
You can ignore it.
Thanks.
--
nvpublic