Skip to contentSkip to conversation

Staging: panel: Fixed a macro coding style issue

PATCH In review Adil Mujeeb 2 participants 2 messages Sep 19, 2012 – Sep 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: panel: Fixed a macro coding style issue

Removed do {} while (0) loop for a single statement macros

---
 linux-3.6-rc6/drivers/staging/panel/panel.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
linux-3.6-rc6/drivers/staging/panel/panel.c +2 -2
index 39f9982..d9fec5b 100644
@@ -137,8 +137,8 @@
 #define r_ctr(x)        (parport_read_control((x)->port))
 #define r_dtr(x)        (parport_read_data((x)->port))
 #define r_str(x)        (parport_read_status((x)->port))
-#define w_ctr(x, y)     do { parport_write_control((x)->port, (y)); } while (0)
-#define w_dtr(x, y)     do { parport_write_data((x)->port, (y)); } while (0)
+#define w_ctr(x, y)     (parport_write_control((x)->port, (y)))
+#define w_dtr(x, y)     (parport_write_data((x)->port, (y)))
 
 /* this defines which bits are to be used and which ones to be ignored */
 /* logical or of the output bits involved in the scan matrix */
Signature · 1 line
1.7.7.3
#1 lore raw
Quoted 3 lines · Adil Mujeeb

Removed do {} while (0) loop for a single statement macros

Also this patch doesn't apply with -p1.

Send the email to yourself. Save the raw email including headers and everything.

cd linux-3.6-rc6
cat raw_email.txt | git am
use git log -p to review the commit log.

regards,
dan carpenter