Skip to contentSkip to conversation

mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

PATCH Superseded Josh Wu 4 participants 7 messages Sep 11, 2012 – Sep 23, 2012

Subsystems (3)
Memory technology devices (MTD) Arm/Microchip (AT91) SoC support NAND flash
lore
Share & tools
lore

Josh Wu

author
#0 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

This error was introduced in b654a9a46fc2100b318050483f8c5b5d0f187303 (mtd: atmel nand: fix gpio missing request)

Signed-off-by Josh Wu <[email protected]>

---
change logs:
Add detail information for the commit message.

 drivers/mtd/nand/atmel_nand.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mtd/nand/atmel_nand.c +2 -1
index 6a5a35b..9144557 100644
@@ -1399,7 +1399,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
 	if (pdev->dev.of_node) {
 		res = atmel_of_init_port(host, pdev->dev.of_node);
 		if (res)
-			goto err_nand_ioremap;
+			goto err_ecc_ioremap;
 	} else {
 		memcpy(&host->board, pdev->dev.platform_data,
 		       sizeof(struct atmel_nand_data));

@@ -1560,6 +1560,7 @@ err_no_card:
 	platform_set_drvdata(pdev, NULL);
 	if (host->dma_chan)
 		dma_release_channel(host->dma_chan);
+err_ecc_ioremap:
 	iounmap(host->io_base);
 err_nand_ioremap:
 	kfree(host);
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

Hi, Artem

Do you have any feedback since there is a long time about this patch?

Best Regards,
Josh Wu

Quoted 42 lines · Josh Wu

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

This error was introduced in b654a9a46fc2100b318050483f8c5b5d0f187303 (mtd: atmel nand: fix gpio missing request)

Signed-off-by Josh Wu <[email protected]>

---
change logs:
Add detail information for the commit message.

  drivers/mtd/nand/atmel_nand.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mtd/nand/atmel_nand.c +2 -1
index 6a5a35b..9144557 100644
@@ -1399,7 +1399,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
  	if (pdev->dev.of_node) {
  		res = atmel_of_init_port(host, pdev->dev.of_node);
  		if (res)
-			goto err_nand_ioremap;
+			goto err_ecc_ioremap;
  	} else {
  		memcpy(&host->board, pdev->dev.platform_data,
  		       sizeof(struct atmel_nand_data));

@@ -1560,6 +1560,7 @@ err_no_card:
  	platform_set_drvdata(pdev, NULL);
  	if (host->dma_chan)
  		dma_release_channel(host->dma_chan);
+err_ecc_ioremap:
  	iounmap(host->io_base);
  err_nand_ioremap:
  	kfree(host);
#2 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

In reply to Josh Wu
Quoted 10 lines · Josh Wu

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

switch to devm_xxx instead this will simplify the error patch and remove patch

Best Regards,
J.

#3 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

On 09/20/2012 07:23 AM, Jean-Christophe PLAGNIOL-VILLARD :

Quoted 11 lines · Josh Wu
Quoted 10 lines

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

Quoted 1 line

switch to devm_xxx instead this will simplify the error patch and remove patch

As far as I understand, it is a correction patch: so my advice would be to take this patch for fixing the current code (for 3.7 if I recall well). If we want to move to the new devm_xxx API, we can do it once the current code is fixed.

Bye,

Signature · 1 line
Nicolas Ferre
author
#4 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

In reply to Jean-Christophe PLAGNIOL-VILLARD

Hi, J.C

Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 10 lines · Josh Wu

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

Quoted 1 line

switch to devm_xxx instead this will simplify the error patch and remove patch

understood. I will push a patch which use devm_xxx. That should remove many code of the error handling. Thanks

Best Regards,
Josh Wu

Quoted 3 lines

Best Regards,
J.

Applied
#5 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

In reply to Josh Wu
Quoted 10 lines · Josh Wu

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

Pushed to l2-mtd.git, thanks!

Signature · 9 lines
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120923/26001d36/attachment.sig>
#6 lore raw

PATCH v2 1/1 mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".

Quoted 12 lines · Artem Bityutskiy
Quoted 10 lines · Josh Wu

Add err_ecc_ioremap label to fix following errors:
---8<---
CC drivers/mtd/nand/atmel_nand.o
drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
make[2]: *** [drivers/mtd/nand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
--->8---

Quoted 1 line

Pushed to l2-mtd.git, thanks!

Actually squashed it into the bogus patch.

Signature · 9 lines
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120923/d7f838a4/attachment.sig>