perf test: Fix build failure
Namhyung Kim
maintainerPATCH 1/1 perf test: Fix build failure
From: Namhyung Kim <[email protected]>
The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields") added following build error:
CC builtin-test.obuiltin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
--- tools/perf/builtin-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/builtin-test.c +2 -2
@@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name, ret =-1 ; } -return 0 ; +return ret; }static int perf_evsel__tp_sched_test (void )
@@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)if (perf_evsel__test_field (evsel,"target_cpu" ,4 , true)) ret =-1 ; -return 0 ; +return ret; } static struct test {
Signature · 1 line
1.7.11.4
Em Tue, Sep 25, 2012 at 11:20:28AM +0900, Namhyung Kim escreveu:
Quoted 5 lines
From: Namhyung Kim <[email protected]>
The commit
6a6cd11d4e57("perf test: Add test for the sched tracepoint format fields") added following build error:
Quoted 7 lines
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
Interesting :-\
[acme@sandy linux]$ gcc --version
gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
Didn't catch this one...
Thanks,
- Arnaldo
Quoted 29 lines
Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/builtin-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/builtin-test.c +2
-2@@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name, ret =-1 ; } -return 0 ; +return ret; }static int perf_evsel__tp_sched_test (void )@@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)if (perf_evsel__test_field (evsel,"target_cpu" ,4 , true)) ret =-1 ; -return 0 ; +return ret; } static struct test {Signature · 1 line
1.7.11.4
Quoted 15 lines · Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 11:20:28AM +0900, Namhyung Kim escreveu:
Quoted 5 lines
From: Namhyung Kim <[email protected]>
The commit
6a6cd11d4e57("perf test: Add test for the sched tracepoint format fields") added following build error:Quoted 7 lines
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
Quoted 4 lines
Interesting :-\
[acme@sandy linux]$ gcc --version
gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
This caught it here:
gcc version 4.7.0 20120507 (Red Hat 4.7.0-5) (GCC)
Thanks,
Ingo
Commit-ID: af9da88f14cbe6882b13492b59b3363682427b4d Gitweb: http://git.kernel.org/tip/af9da88f14cbe6882b13492b59b3363682427b4d Author: Namhyung Kim <[email protected]> AuthorDate: Tue, 25 Sep 2012 11:20:28 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 25 Sep 2012 07:45:59 -0300
perf test: Fix build failure
The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields") added following build error:
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
--- tools/perf/builtin-test.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
tools/perf/builtin-test.c +2 -2
@@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name, ret =-1 ; } -return 0 ; +return ret; }static int perf_evsel__tp_sched_test (void )
@@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)if (perf_evsel__test_field (evsel,"target_cpu" ,4 , true)) ret =-1 ; -return 0 ; +return ret; } static struct test {